From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.chez-thomas.org (mail.mlbassoc.com [65.100.170.105]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id BB4BCE006C3 for ; Tue, 19 Mar 2013 06:41:21 -0700 (PDT) Received: by mail.chez-thomas.org (Postfix, from userid 1998) id E2A03F811EB; Tue, 19 Mar 2013 07:41:20 -0600 (MDT) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on hermes.chez-thomas.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=4.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 Received: from [192.168.1.114] (zeus [192.168.1.114]) by mail.chez-thomas.org (Postfix) with ESMTP id D31D0F811E6; Tue, 19 Mar 2013 07:41:18 -0600 (MDT) Message-ID: <51486B02.6000006@gmail.com> Date: Tue, 19 Mar 2013 07:41:22 -0600 From: Gary Thomas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Otavio Salvador References: <514865F8.8020009@gmail.com> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm][PATCH] xf86-dri-vivante: Fix build with latest X server base X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2013 13:41:22 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 2013-03-19 07:33, Otavio Salvador wrote: > On Tue, Mar 19, 2013 at 10:19 AM, Gary Thomas wrote: >> mibstore functions are no longer supported. This patch >> removes them from this driver. >> >> Signed-off-by: Gary Thomas >> --- >> .../xf86-dri-vivante/remove-mibstore.patch | 24 >> ++++++++++++++++++++ >> .../xorg-driver/xf86-dri-vivante_12.09.01.bb | 4 +++- >> 2 files changed, 27 insertions(+), 1 deletion(-) >> create mode 100644 >> recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch >> >> diff --git >> a/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch >> b/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch >> new file mode 100644 >> index 0000000..1c48563 >> --- /dev/null >> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch >> @@ -0,0 +1,24 @@ >> +Index: >> xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h >> +=================================================================== >> +--- >> xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_util/vivante_common.h >> ++++ xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h >> +@@ -48,7 +48,6 @@ extern "C" { >> + + + #include "mipointer.h" >> +-#include "mibstore.h" >> + #include "micmap.h" >> + #include "mipointrst.h" >> + #include "inputstr.h" >> +Index: >> xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c >> +=================================================================== >> +--- >> xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_fbdev/vivante_fbdev_driver.c >> ++++ >> xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c >> +@@ -746,7 +746,6 @@ VivScreenInit(SCREEN_INIT_ARGS_DECL) { >> + + + xf86SetBlackWhitePixels(pScreen); >> +- miInitializeBackingStore(pScreen); >> + xf86SetBackingStore(pScreen); >> + + pScrn->vtSema = TRUE; > > What the side effects of this change? Unknown, but it seems to work fine. I found this same change in other drivers in OE, e.g. http://patches.openembedded.org/patch/46133/ This checkin shows when/where that file was deleted and mentions the reasons. http://lists.x.org/archives/xorg-devel/2012-September/033575.html > >> diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb >> b/recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb >> index acc5479..9f63fb8 100644 >> --- a/recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb >> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb >> @@ -6,7 +6,9 @@ SECTION = "x11/base" >> DEPENDS = "virtual/libx11 util-macros xf86-video-imxfb-vivante" >> LIC_FILES_CHKSUM = >> "file://src/dri.h;enline=27;md5=79a9064e49ae41adca4827cd2281a014" >> -SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true" >> +SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true \ >> + file://remove-mibstore.patch \ >> +" >> SRC_URI[md5sum] = "8c90045cd5f4dba81095856634ba5136" >> SRC_URI[sha256sum] = >> "c844dc180e43901359bbdb4f797ab178b3821fbf63bdee9577e5a0afe5d7f6ad" >> -- 1.7.9.5