From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43384)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1UHzHT-0008Lg-Lq
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 12:20:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1UHzHQ-0008M5-8q
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 12:20:55 -0400
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:33823 helo=mx01.kamp.de)
	by eggs.gnu.org with smtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1UHzHP-0008KC-Vb
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 12:20:52 -0400
Message-ID: <51488A1F.1080401@kamp.de>
Date: Tue, 19 Mar 2013 16:54:07 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1363681158-26122-1-git-send-email-pl@kamp.de>
	<87a9pzojr5.fsf@blackfin.pond.sub.org>
	<5148496A.3050201@redhat.com>
In-Reply-To: <5148496A.3050201@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 19.03.2013 12:18, Paolo Bonzini wrote:
> Il 19/03/2013 09:51, Markus Armbruster ha scritto:
>> Paolo, please have a look.
> Why isn't it enough to call bdrv_init_with_whitelist earlier?
>
> There is no conditional logic in it, the whitelist is checked at open time.

Has anyone tested if -spice is working? In this case bdrv_init_with_whitelist() won't help here.

Anyway, I would like to change the -iscsi code in vl.c to throw an error, if iscsi support is not
compiled in (like it is done with spice).

Peter

>
> Paolo
>
>> Peter Lieven <pl@kamp.de> writes:
>>
>>> current git master segfaults if an iscsi option is specified
>>> in command line.
>>>
>>> Peter Lieven (2):
>>>    qemu-option: avoid segfault if QemuOptsList == NULL
>>>    vl.c: fix segfault in iscsi options parsing
>>>
>>>   block/iscsi.c      |   27 ---------------------------
>>>   util/qemu-option.c |    1 +
>>>   vl.c               |   40 +++++++++++++++++++++++++++++++++++++---
>>>   3 files changed, 38 insertions(+), 30 deletions(-)
>>


-- 

Mit freundlichen Grüßen

Peter Lieven

...........................................................

   KAMP Netzwerkdienste GmbH
   Vestische Str. 89-91 | 46117 Oberhausen
   Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40
   pl@kamp.de | http://www.kamp.de

   Geschäftsführer: Heiner Lante | Michael Lante
   Amtsgericht Duisburg | HRB Nr. 12154
   USt-Id-Nr.: DE 120607556

...........................................................