From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI0Cq-00050h-2y for qemu-devel@nongnu.org; Tue, 19 Mar 2013 13:20:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UI0Cn-0006xo-H2 for qemu-devel@nongnu.org; Tue, 19 Mar 2013 13:20:12 -0400 Message-ID: <51489E47.5040204@adacore.com> Date: Tue, 19 Mar 2013 18:20:07 +0100 From: Fabien Chouteau MIME-Version: 1.0 References: <1363694598-19799-1-git-send-email-chouteau@adacore.com> <1F098328-BA3A-40BC-955B-9CDFF470D257@suse.de> <514880BD.8040009@adacore.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org On 03/19/2013 04:23 PM, Peter Maydell wrote: > On 19 March 2013 15:14, Fabien Chouteau wrote: >> I can if I include helper.h, unfortunately this file is named helpers.h >> (note the 's') for m68k so I wont be able to include it for all >> platforms. > > The way we do this on ARM for cpsr_read is: > * cpsr_read() is defined in target-arm/cpu.h > * gdbstub.c calls cpsr_read() > * HELPER(cpsr_read) is mostly a wrapper calling cpsr_read() > * helper.h declares HELPER(cpsr_read) as usual > > I'm not sure you want to include helper.h. > Cleaner solution indeed. I'll do the opposite, store_fpscr calls helper_store_fpscr. Thanks, -- Fabien Chouteau