From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Joe Perches <joe@perches.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH 1/3] kernel/srcu: merge common code into a macro
Date: Tue, 19 Mar 2013 19:15:53 +0100 [thread overview]
Message-ID: <5148AB59.6080000@linutronix.de> (raw)
In-Reply-To: <1363710160.1932.49.camel@joe-AO722>
On 03/19/2013 05:22 PM, Joe Perches wrote:
>> +#define DEFINE_SRCU(name) _DEFINE_SRCU(name, )
>> +#define DEFINE_STATIC_SRCU(name) _DEFINE_SRCU(name, static)
>
> I think the use of an empty argument, even in
> a macro, unsightly.
__wait_event_lock_irq() => __wait_event_lock_irq() is a prominent user.
I would prefer to avoid adding something like /* nothing */.
Sebastian
next prev parent reply other threads:[~2013-03-19 18:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 14:16 [PATCH 1/3] kernel/srcu: merge common code into a macro Sebastian Andrzej Siewior
2013-03-19 14:16 ` [PATCH 2/3] kernel/SRCU: provide a static initializer Sebastian Andrzej Siewior
2013-04-05 7:21 ` Lai Jiangshan
2013-04-08 10:03 ` Sebastian Andrzej Siewior
2013-04-09 1:09 ` Lai Jiangshan
2013-04-11 17:04 ` Sebastian Andrzej Siewior
2013-04-12 2:56 ` Lai Jiangshan
2013-04-16 18:20 ` Paul E. McKenney
2013-03-19 14:16 ` [PATCH 3/3] cpufreq: use static initializer for the SRCU notifier Sebastian Andrzej Siewior
2013-03-19 16:22 ` [PATCH 1/3] kernel/srcu: merge common code into a macro Joe Perches
2013-03-19 18:15 ` Sebastian Andrzej Siewior [this message]
2013-04-05 7:21 ` Lai Jiangshan
2013-04-08 10:05 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148AB59.6080000@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=joe@perches.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.