From: Richard Henderson <rth@twiddle.net>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr
Date: Tue, 19 Mar 2013 11:32:34 -0700 [thread overview]
Message-ID: <5148AF42.7000103@twiddle.net> (raw)
In-Reply-To: <51489E47.5040204@adacore.com>
On 03/19/2013 10:20 AM, Fabien Chouteau wrote:
> Cleaner solution indeed. I'll do the opposite, store_fpscr calls helper_store_fpscr.
The declarations won't be in the right places for that to work right.
Canonically, cpu_store_fpscr should be declared in cpu.h, have the leading
"cpu_" prefix, and then helper_store_fpscr is declared (via macro) in helper.h
and its definition should call the cpu.h function.
r~
next prev parent reply other threads:[~2013-03-19 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 12:03 [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr Fabien Chouteau
2013-03-19 12:10 ` Alexander Graf
2013-03-19 12:13 ` Peter Maydell
2013-03-19 12:16 ` Alexander Graf
2013-03-19 15:14 ` Fabien Chouteau
2013-03-19 15:23 ` Peter Maydell
2013-03-19 17:20 ` Fabien Chouteau
2013-03-19 17:21 ` Peter Maydell
2013-03-19 18:32 ` Richard Henderson [this message]
2013-03-19 19:48 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148AF42.7000103@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=chouteau@adacore.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.