All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] x86: let userspace inject interrupts into the local APIC
Date: Tue, 19 Mar 2013 19:39:24 +0100	[thread overview]
Message-ID: <5148B0DC.9000609@redhat.com> (raw)
In-Reply-To: <20130319181323.GL19292@redhat.com>

Il 19/03/2013 19:13, Gleb Natapov ha scritto:
>> > There is no way for userspace to inject interrupts into a VCPU's
>> > local APIC, which is important in order to inject INITs coming from
>> > the chipset.  KVM_INTERRUPT is currently disabled when the in-kernel
>> > local APIC is used, so we can repurpose it.  The shorthand destination
>> > field must contain APIC_DEST_SELF, which has a double effect: first,
>> > the ICR2 register is not used and the 32-bit field of KVM_INTERRUPT is
>> > enough; second, it ensures that the valid range of the irq field is
>> > distinct in the userspace-APIC and kernel-APIC cases.
>> > 
> Init coming from triggering INIT# line should not be modeled as INIT coming from
> APIC.

Then Jan's patch was wrong, and INIT should not have been an apic event
(perhaps SIPI should).

> In fact INIT cannot be send using SELF shorthand.

Where does the SDM say that?

Paolo

> If APIC code will be fixed to check for that this code will break.

  reply	other threads:[~2013-03-19 18:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 15:51 [PATCH] x86: let userspace inject interrupts into the local APIC Paolo Bonzini
2013-03-19 18:13 ` Gleb Natapov
2013-03-19 18:39   ` Paolo Bonzini [this message]
2013-03-19 18:50     ` Gleb Natapov
2013-03-19 20:22       ` Paolo Bonzini
2013-03-20 10:56         ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5148B0DC.9000609@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.