All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Rob Herring <robherring2@gmail.com>
Cc: rjw@sisk.pl, patches@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] cpuidle / calxeda: remove redundant Kconfig option
Date: Tue, 19 Mar 2013 23:03:20 +0100	[thread overview]
Message-ID: <5148E0A8.70208@linaro.org> (raw)
In-Reply-To: <514880AF.7010404@gmail.com>

On 03/19/2013 04:13 PM, Rob Herring wrote:
> On 03/19/2013 09:35 AM, Daniel Lezcano wrote:
>> On 03/19/2013 01:22 PM, Rob Herring wrote:
>>> On 03/12/2013 04:27 AM, Daniel Lezcano wrote:
>>>> When the CPU_IDLE and the ARCH_HIGHBANK options are set it is
>>>> pointless to define a new option CPU_IDLE_CALXEDA because it
>>>> is redundant.
>>>>
>>>> The Makefile drivers directory contains a condition to compile
>>>> the cpuidle drivers:
>>>>
>>>> obj-$(CONFIG_CPU_IDLE)          += cpuidle/
>>>>
>>>> Hence, if CPU_IDLE is not set we won't enter this directory.
>>>>
>>>> This patch removes the useless Kconfig option and replaces the
>>>> condition in the Makefile by CONFIG_ARCH_HIGHBANK.
>>>
>>> If I have multiple platforms including highbank compiled in, but want to
>>> disable cpuidle just for highbank, then you can't disable it at compile
>>> time.
>>
>> Could you elaborate a bit ? Is it today possible to have multiple
>> platforms in a single kernel ?
> 
> You've heard of single zImage, right? Vexpress, mvebu, highbank, imx,
> omap2+, socfpga, vt8500 off the top of my head as of 3.8.

Yes, I have heard of single zImage but I am not aware of the status.

IIUC, the approach would be the same as cpufreq, right ?

I am not sure the cpuidle drivers are ready for that.

We can keep the current Makefile but I am in favor of removing this
Kconfig option for now, unify as much as possible all the drivers,
create a common driver for all and then address the single zImage for
all these drivers at the same time.



-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] cpuidle / calxeda: remove redundant Kconfig option
Date: Tue, 19 Mar 2013 23:03:20 +0100	[thread overview]
Message-ID: <5148E0A8.70208@linaro.org> (raw)
In-Reply-To: <514880AF.7010404@gmail.com>

On 03/19/2013 04:13 PM, Rob Herring wrote:
> On 03/19/2013 09:35 AM, Daniel Lezcano wrote:
>> On 03/19/2013 01:22 PM, Rob Herring wrote:
>>> On 03/12/2013 04:27 AM, Daniel Lezcano wrote:
>>>> When the CPU_IDLE and the ARCH_HIGHBANK options are set it is
>>>> pointless to define a new option CPU_IDLE_CALXEDA because it
>>>> is redundant.
>>>>
>>>> The Makefile drivers directory contains a condition to compile
>>>> the cpuidle drivers:
>>>>
>>>> obj-$(CONFIG_CPU_IDLE)          += cpuidle/
>>>>
>>>> Hence, if CPU_IDLE is not set we won't enter this directory.
>>>>
>>>> This patch removes the useless Kconfig option and replaces the
>>>> condition in the Makefile by CONFIG_ARCH_HIGHBANK.
>>>
>>> If I have multiple platforms including highbank compiled in, but want to
>>> disable cpuidle just for highbank, then you can't disable it at compile
>>> time.
>>
>> Could you elaborate a bit ? Is it today possible to have multiple
>> platforms in a single kernel ?
> 
> You've heard of single zImage, right? Vexpress, mvebu, highbank, imx,
> omap2+, socfpga, vt8500 off the top of my head as of 3.8.

Yes, I have heard of single zImage but I am not aware of the status.

IIUC, the approach would be the same as cpufreq, right ?

I am not sure the cpuidle drivers are ready for that.

We can keep the current Makefile but I am in favor of removing this
Kconfig option for now, unify as much as possible all the drivers,
create a common driver for all and then address the single zImage for
all these drivers at the same time.



-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2013-03-19 22:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12  9:27 [PATCH 1/2] cpuidle / kirkwood: remove redundant Kconfig option Daniel Lezcano
2013-03-12  9:27 ` Daniel Lezcano
2013-03-12  9:27 ` [PATCH 2/2] cpuidle / calxeda: " Daniel Lezcano
2013-03-12  9:27   ` Daniel Lezcano
2013-03-19 11:49   ` Daniel Lezcano
2013-03-19 11:49     ` Daniel Lezcano
2013-03-19 12:22   ` Rob Herring
2013-03-19 12:22     ` Rob Herring
2013-03-19 14:35     ` Daniel Lezcano
2013-03-19 14:35       ` Daniel Lezcano
2013-03-19 15:13       ` Rob Herring
2013-03-19 15:13         ` Rob Herring
2013-03-19 22:03         ` Daniel Lezcano [this message]
2013-03-19 22:03           ` Daniel Lezcano
2013-03-12 11:22 ` [PATCH 1/2] cpuidle / kirkwood: " Jason Cooper
2013-03-12 11:22   ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5148E0A8.70208@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rjw@sisk.pl \
    --cc=robherring2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.