From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Andy Gross <andy.gross@ti.com>
Cc: linux-omap@vger.kernel.org, Benoit Cousson <b-cousson@ti.com>,
devicetree-discuss@lists.ozlabs.org, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH 1/2] ARM: dts: OMAP4+: Add DMM bindings
Date: Wed, 20 Mar 2013 11:29:59 +0530 [thread overview]
Message-ID: <5149505F.7080105@ti.com> (raw)
In-Reply-To: <1363754624-5209-2-git-send-email-andy.gross@ti.com>
On Wednesday 20 March 2013 10:13 AM, Andy Gross wrote:
> Add DMM bindings for OMAP4 and OMAP5 devices.
>
> Signed-off-by: Andy Gross <andy.gross@ti.com>
> ---
> arch/arm/boot/dts/omap4.dtsi | 7 +++++++
> arch/arm/boot/dts/omap5.dtsi | 7 +++++++
> 2 files changed, 14 insertions(+), 0 deletions(-)
>
"Documentation/devicetree/bindings/arm/omap/dmm.txt | 16 ++++++++++++++++
You should add the bidning information along or before
adding the DT node. I see you have that in next patch.
You should move that as part of this patch to be
consistent. Otherwise patch looks fine to me.
Regards,
Santosh
next prev parent reply other threads:[~2013-03-20 5:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 4:43 [PATCH 0/2] ARM: dts: OMAP4+: Add dmm device bindings Andy Gross
2013-03-20 4:43 ` [PATCH 1/2] ARM: dts: OMAP4+: Add DMM bindings Andy Gross
2013-03-20 5:59 ` Santosh Shilimkar [this message]
2013-03-20 4:43 ` [PATCH 2/2] ARM: OMAP2+: Remove dmm device creation Andy Gross
2013-03-20 5:56 ` Santosh Shilimkar
2013-03-20 6:16 ` Archit Taneja
2013-03-20 6:22 ` Santosh Shilimkar
2013-03-20 6:28 ` Gross, Andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149505F.7080105@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=andy.gross@ti.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.