From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Matthew Garrett
<matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
Cc: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: EFI: Stash ROMs if they're not in the PCI BAR
Date: Wed, 20 Mar 2013 08:44:35 +0000 [thread overview]
Message-ID: <514976F3.2@console-pimps.org> (raw)
In-Reply-To: <1363622520.2553.8.camel-tCUS0Eywp2Pehftex57rkxo58HMYffqeLoYNBG0abjxeoWH0uzbU5w@public.gmane.org>
On 03/18/2013 04:02 PM, Matthew Garrett wrote:
> On Mon, 2013-03-18 at 11:36 +0000, Matt Fleming wrote:
>> On Fri, 2013-03-15 at 08:57 +0000, David Woodhouse wrote:
>>> True. It probably doesn't *matter* because the size is zero so the
>>> firmware is just going to ignore the pointer anyway. Although in that
>>> case I wonder why we couldn't have just passed NULL. Perhaps we expected
>>> that some firmware might do some validation on the pointer before
>>> getting to the size check?
>>
>> I doubt that the firmware checks the validity of pci_handle when size is
>> zero, and I agree it's worth passing NULL to silence the warning (which
>> is also more explicit that just initialising pci_handle), unless Matthew
>> knows of a reason we shouldn't do that?
>
> No reason I can think of, and any failure will be pretty immediately
> obvious.
Anyone want to submit a patch?
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-03-20 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 8:29 EFI: Stash ROMs if they're not in the PCI BAR Dan Carpenter
[not found] ` <20130315082928.GA14520-dZEljifmRObu9KfB+GxooP8+0UxHXcjY@public.gmane.org>
2013-03-15 8:57 ` David Woodhouse
[not found] ` <1363337872.2444.9.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2013-03-18 11:36 ` Matt Fleming
[not found] ` <1363606563.15011.333.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-18 16:02 ` Matthew Garrett
[not found] ` <1363622520.2553.8.camel-tCUS0Eywp2Pehftex57rkxo58HMYffqeLoYNBG0abjxeoWH0uzbU5w@public.gmane.org>
2013-03-20 8:44 ` Matt Fleming [this message]
[not found] ` <514976F3.2-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-03-20 9:09 ` Dan Carpenter
2013-03-20 9:27 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514976F3.2@console-pimps.org \
--to=matt-hnk1s37rvnbexh+ff434mdi2o/jbrioy@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.