Re: [LTP] [PATCH] inode01: remove "slash" array

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 03/20/2013 05:44 PM, Jan Stancek wrote:
> and replace strcats with snprintf.
> 
> Signed-off-by: Jan Stancek <jstancek@redhat.com>

Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

> ---
>  testcases/kernel/fs/inode/inode01.c |   26 ++++++++++++++++----------
>  1 files changed, 16 insertions(+), 10 deletions(-)
> 
> diff --git a/testcases/kernel/fs/inode/inode01.c b/testcases/kernel/fs/inode/inode01.c
> index 9643651..b3a9a0b 100644
> --- a/testcases/kernel/fs/inode/inode01.c
> +++ b/testcases/kernel/fs/inode/inode01.c
> @@ -96,7 +96,6 @@ char rm_string[200];
>  FILE *list_stream = NULL;
>  int file_id;
>  int list_id;
> -char slash[2];
>  
>  int increment_name(), get_next_name(), mode(), escrivez();
>  
> @@ -110,9 +109,7 @@ int main()
>  	int status;
>  	int len;
>  	int term();
> -
> -	slash[0] = '/';
> -	slash[1] = '\0';
> +	int snp_ret;
>  
>  	strcpy(path_string, "inode");
>  	sprintf(root, "A%d", getpid());
> @@ -160,9 +157,13 @@ int main()
>  	/*                                      */
>  	/****************************************/
>  
> -	strcpy(path_list_string, path_string);
> -	strcat(path_list_string, slash);
> -	strcat(path_list_string, "path_list");
> +	snp_ret = snprintf(path_list_string, sizeof(path_list_string),
> +		"%s/path_list",	path_string);
> +	if (snp_ret < 0 || snp_ret >= sizeof(path_list_string)) {
> +		tst_resm(TBROK, "snprintf(path_list_string,..) returned %d",
> +			snp_ret);
> +		fail_exit();
> +	}
>  	list_id = creat(path_list_string, FILE_MODE);
>  	if (list_id == -1) {
>  		fprintf(temp,
> @@ -308,6 +309,7 @@ int level;			/* the tree depth variable */
>  	char new_string[PATH_STRING_LENGTH + 1];
>  	int new_level;
>  	int i, j;		/* iteration counters */
> +	int snp_ret;
>  
>  	switch_flag = level & TRUE;
>  	if (strlen(string) >= MAX_PATH_STRING_LENGTH) {
> @@ -324,9 +326,13 @@ int level;			/* the tree depth variable */
>  	} else if (level < MAX_DEPTH) {
>  		for (i = 0; i <= MAX_BREADTH; i++) {
>  			get_next_name();
> -			strcpy(new_string, string);
> -			strcat(new_string, slash);
> -			strcat(new_string, name);
> +			snp_ret = snprintf(new_string, sizeof(new_string),
> +				"%s/%s", string, name);
> +			if (snp_ret < 0 || snp_ret >= sizeof(new_string)) {
> +				tst_resm(TBROK, "snprintf(new_string,..) "
> +					"returned %d", snp_ret);
> +				fail_exit();
> +			}
>  
>  			/****************************************/
>  			/*                                      */
> 


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list