From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] ACPI/ERST: Name ERST table in otherwise opaque error messages Date: Wed, 20 Mar 2013 11:29:04 +0000 Message-ID: <51499D80.5070401@citrix.com> References: <7fdef201c0b40c535c29.1363733731@andrewcoop.uk.xensource.com> <514982C602000078000C70AB@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <514982C602000078000C70AB@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "Keir (Xen.org)" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 20/03/13 08:35, Jan Beulich wrote: >>>> On 19.03.13 at 23:55, Andrew Cooper wrote: >> Signed-off-by: Andrew Cooper >> >> diff -r a6b81234b189 -r 7fdef201c0b4 xen/drivers/acpi/apei/erst.c >> --- a/xen/drivers/acpi/apei/erst.c >> +++ b/xen/drivers/acpi/apei/erst.c >> @@ -781,11 +781,11 @@ int __init erst_init(void) >> status = acpi_get_table(ACPI_SIG_ERST, 0, >> (struct acpi_table_header **)&erst_tab); >> if (status == AE_NOT_FOUND) { >> - printk(KERN_ERR "Table is not found!\n"); >> + printk(KERN_ERR "ERST table is not found!\n"); >> return -ENODEV; >> } else if (ACPI_FAILURE(status)) { >> const char *msg = acpi_format_exception(status); >> - printk(KERN_ERR "Failed to get table, %s\n", msg); >> + printk(KERN_ERR "Failed to get ESRT table, %s\n", msg); > I'll fix the spelling, and once at it also lower the severities (these > really aren't errors - the former is informational, while the latter > is no more than a warning imo). > > Jan Thanks - I realised the spelling error after I left last night and was going to submit a correction if you hadn't beaten me to it. ~Andrew