From: Stephen Warren <swarren@wwwdotorg.org>
To: balbi@ti.com
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>,
USB list <linux-usb@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: USB-related build errors on Tegra in next-20130319
Date: Wed, 20 Mar 2013 11:26:50 -0600 [thread overview]
Message-ID: <5149F15A.1000806@wwwdotorg.org> (raw)
In-Reply-To: <20130320171147.GM1567@arwen.pp.htv.fi>
On 03/20/2013 11:11 AM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Mar 20, 2013 at 10:51:49AM -0600, Stephen Warren wrote:
>> On 03/20/2013 10:45 AM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Wed, Mar 20, 2013 at 10:39:11AM -0600, Stephen Warren
>>> wrote:
>>>> On 03/20/2013 06:20 AM, Felipe Balbi wrote:
>> ...
>>>> The patch you gave fixes the Kconfig warnings, but not the
>>>> build failure.
>> ...
>>>> For now, I think the correct solution is to have
>>>> USB_EHCI_TEGRA select USB_PHY. I validated that solves the
>>>> build problem, and has the bonus of not needing any changes
>>>> to tegra_defconfig.
>> ...
>>> Alright, do you want to send that patch ? My bad that I missed
>>> that build error...
>>
>> Sure. Do you want to roll it into your patch and repost it, or me
>> to send a separate patch?
Oops, sorry, I meant to write "Do you want *me* to" ...
> updated patch below:
Anyway, the updated patch you sent does solve the problem, so:
Acked-by: Stephen Warren <swarren@nvidia.com>
Tested-by: Stephen Warren <swarren@nvidia.com>
(both build and ran it on HW to make sure nothing was missing)
Feel free to use yours or the separate one I sent; entirely your call.
next prev parent reply other threads:[~2013-03-20 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 16:29 USB-related build errors on Tegra in next-20130319 Stephen Warren
2013-03-20 12:20 ` Felipe Balbi
[not found] ` <20130320122031.GI29659-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-03-20 16:39 ` Stephen Warren
[not found] ` <5149E62F.9090705-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-20 16:45 ` Felipe Balbi
[not found] ` <20130320164553.GL1567-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-03-20 16:51 ` Stephen Warren
2013-03-20 17:11 ` Felipe Balbi
2013-03-20 17:26 ` Stephen Warren [this message]
[not found] ` <5149F15A.1000806-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-20 17:30 ` Felipe Balbi
2013-03-20 17:42 ` Stephen Warren
2013-03-20 17:56 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149F15A.1000806@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=balbi@ti.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.