From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Denis Kirjanov <kda@linux-powerpc.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com
Subject: Re: [PATCH 2/2] sh_eth: check TSU registers ioremap() error
Date: Wed, 20 Mar 2013 22:45:45 +0300 [thread overview]
Message-ID: <514A11E9.1070708@cogentembedded.com> (raw)
In-Reply-To: <CAOJe8K2aoQLi0B4SaHEv0GPMe2g0YvuRQc1vwBZhLVJPZLsYCQ@mail.gmail.com>
Hello.
On 03/20/2013 09:20 PM, Denis Kirjanov wrote:
> It doesn't make sense to worry about branch misprediction during probe() :)
You misunderstood. I didn't mean using unlikely() at all, just that
the ioremap() failure is unlikely.
PS: Please, don't top post.
> On 3/20/13, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
>> On 03/20/2013 10:04 PM, Sergei Shtylyov wrote:
>>
>>>>> One must check the result of ioremap() -- in this case it prevents
>>>>> potential
>>>>> kernel oops when initializing TSU registers further on...
>>>>>
>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> Applied and queued up for -stable.
>>> Thanks. However, do you really think it's needed in stable? It's
>>> only error path, after all...
>> I forgot to add "unlikely" to the "error path". I usually don't mark
>> such patches for stable, when I'm not in a hurry. :-)
>>
WBR, Sergei
prev parent reply other threads:[~2013-03-20 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 23:41 [PATCH 2/2] sh_eth: check TSU registers ioremap() error Sergei Shtylyov
2013-03-20 16:23 ` David Miller
2013-03-20 19:04 ` Sergei Shtylyov
2013-03-20 19:16 ` Sergei Shtylyov
2013-03-20 18:20 ` Denis Kirjanov
2013-03-20 19:45 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514A11E9.1070708@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=kda@linux-powerpc.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.