From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon Subject: Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework Date: Thu, 21 Mar 2013 11:16:39 +0530 Message-ID: <514A9EBF.4030505@ti.com> References: <1363770725-13717-1-git-send-email-kishon@ti.com> <1363770725-13717-2-git-send-email-kishon@ti.com> <514A39E3.6090501@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <514A39E3.6090501@gmail.com> Sender: linux-doc-owner@vger.kernel.org To: Sylwester Nawrocki Cc: balbi@ti.com, gregkh@linuxfoundation.org, arnd@arndb.de, akpm@linux-foundation.org, rob@landley.net, broonie@opensource.wolfsonmicro.com, linux@arm.linux.org.uk, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, eballetbo@gmail.com, santosh.shilimkar@ti.com, linux-arm-kernel@lists.infradead.org, swarren@nvidia.com, javier@dowhile0.org, linux-omap@vger.kernel.org, davem@davemloft.net, cesarb@cesarb.net, mchehab@redhat.com List-Id: linux-omap@vger.kernel.org Hi, On Thursday 21 March 2013 04:06 AM, Sylwester Nawrocki wrote: > Hi Kishon, > > On 03/20/2013 10:12 AM, Kishon Vijay Abraham I wrote: >> The PHY framework provides a set of APIs for the PHY drivers to >> create/destroy a PHY and APIs for the PHY users to obtain a reference >> to the >> PHY with or without using phandle. To obtain a reference to the PHY >> without >> using phandle, the platform specfic intialization code (say from board >> file) >> should have already called phy_bind with the binding information. The >> binding >> information consists of phy's device name, phy user device name and an >> index. >> The index is used when the same phy user binds to mulitple phys. >> >> PHY drivers should create the PHY by passing phy_descriptor that has >> describes the PHY (label, type etc..) and ops like init, exit, >> suspend, resume, >> poweron, shutdown. >> >> The documentation for the generic PHY framework is added in >> Documentation/phy.txt and the documentation for the sysfs entry is added >> in Documentation/ABI/testing/sysfs-class-phy. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- > [...] >> +static inline struct phy *phy_get(struct device *dev, int index) >> +{ >> + return ERR_PTR(-EOPNOTSUPP); > > Shouldn't these be -ENOSYS ? EOPNOTSUPP is defined by POSIX as > "Operation not supported on socket". And EOPNOTSUPP appears to be > mostly used in the network code in the kernel. Fair enough. Will change to ENOSYS. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (kishon) Date: Thu, 21 Mar 2013 11:16:39 +0530 Subject: [PATCH v3 1/6] drivers: phy: add generic PHY framework In-Reply-To: <514A39E3.6090501@gmail.com> References: <1363770725-13717-1-git-send-email-kishon@ti.com> <1363770725-13717-2-git-send-email-kishon@ti.com> <514A39E3.6090501@gmail.com> Message-ID: <514A9EBF.4030505@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thursday 21 March 2013 04:06 AM, Sylwester Nawrocki wrote: > Hi Kishon, > > On 03/20/2013 10:12 AM, Kishon Vijay Abraham I wrote: >> The PHY framework provides a set of APIs for the PHY drivers to >> create/destroy a PHY and APIs for the PHY users to obtain a reference >> to the >> PHY with or without using phandle. To obtain a reference to the PHY >> without >> using phandle, the platform specfic intialization code (say from board >> file) >> should have already called phy_bind with the binding information. The >> binding >> information consists of phy's device name, phy user device name and an >> index. >> The index is used when the same phy user binds to mulitple phys. >> >> PHY drivers should create the PHY by passing phy_descriptor that has >> describes the PHY (label, type etc..) and ops like init, exit, >> suspend, resume, >> poweron, shutdown. >> >> The documentation for the generic PHY framework is added in >> Documentation/phy.txt and the documentation for the sysfs entry is added >> in Documentation/ABI/testing/sysfs-class-phy. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- > [...] >> +static inline struct phy *phy_get(struct device *dev, int index) >> +{ >> + return ERR_PTR(-EOPNOTSUPP); > > Shouldn't these be -ENOSYS ? EOPNOTSUPP is defined by POSIX as > "Operation not supported on socket". And EOPNOTSUPP appears to be > mostly used in the network code in the kernel. Fair enough. Will change to ENOSYS. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753696Ab3CUFre (ORCPT ); Thu, 21 Mar 2013 01:47:34 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:59185 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752110Ab3CUFrc (ORCPT ); Thu, 21 Mar 2013 01:47:32 -0400 Message-ID: <514A9EBF.4030505@ti.com> Date: Thu, 21 Mar 2013 11:16:39 +0530 From: kishon User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Sylwester Nawrocki CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework References: <1363770725-13717-1-git-send-email-kishon@ti.com> <1363770725-13717-2-git-send-email-kishon@ti.com> <514A39E3.6090501@gmail.com> In-Reply-To: <514A39E3.6090501@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 21 March 2013 04:06 AM, Sylwester Nawrocki wrote: > Hi Kishon, > > On 03/20/2013 10:12 AM, Kishon Vijay Abraham I wrote: >> The PHY framework provides a set of APIs for the PHY drivers to >> create/destroy a PHY and APIs for the PHY users to obtain a reference >> to the >> PHY with or without using phandle. To obtain a reference to the PHY >> without >> using phandle, the platform specfic intialization code (say from board >> file) >> should have already called phy_bind with the binding information. The >> binding >> information consists of phy's device name, phy user device name and an >> index. >> The index is used when the same phy user binds to mulitple phys. >> >> PHY drivers should create the PHY by passing phy_descriptor that has >> describes the PHY (label, type etc..) and ops like init, exit, >> suspend, resume, >> poweron, shutdown. >> >> The documentation for the generic PHY framework is added in >> Documentation/phy.txt and the documentation for the sysfs entry is added >> in Documentation/ABI/testing/sysfs-class-phy. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- > [...] >> +static inline struct phy *phy_get(struct device *dev, int index) >> +{ >> + return ERR_PTR(-EOPNOTSUPP); > > Shouldn't these be -ENOSYS ? EOPNOTSUPP is defined by POSIX as > "Operation not supported on socket". And EOPNOTSUPP appears to be > mostly used in the network code in the kernel. Fair enough. Will change to ENOSYS. Thanks Kishon