All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] do not use GIT_TRACE_PACKET=3 in tests
Date: Thu, 21 Mar 2013 07:36:13 +0100	[thread overview]
Message-ID: <514AAA5D.4000803@viscovery.net> (raw)
In-Reply-To: <20130320174347.GA28548@sigill.intra.peff.net>

Am 3/20/2013 18:43, schrieb Jeff King:
> Now that we are using the GIT_TRACE mechanism, we can
> improve both scripts by asking git to write directly to a
> file rather than a descriptor. That fixes the hang in t5700,
> and should allow t5503 to successfully run on Windows.

Well spotted, and, right, both tests pass with this patch.

Tested-by: Johannes Sixt <j6t@kdbg.org>

Thanks,
-- Hannes

  parent reply	other threads:[~2013-03-21  6:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20  8:24 [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git Johannes Sixt
2013-03-20  9:33 ` Jeff King
2013-03-20 11:30   ` Johannes Sixt
2013-03-20 17:06     ` Jeff King
2013-03-20 17:26       ` Jeff King
2013-03-20 17:43         ` [PATCH] do not use GIT_TRACE_PACKET=3 in tests Jeff King
2013-03-20 20:29           ` Eric Sunshine
2013-03-20 20:58             ` Jeff King
2013-03-21  6:36           ` Johannes Sixt [this message]
2013-03-21 15:04             ` Junio C Hamano
2013-03-20 17:30       ` [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514AAA5D.4000803@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.