Re: j1939 - mainline problems

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 21.03.2013 07:05, Kurt Van Dijck wrote:

> On Mon, Mar 18, 2013 at 10:31:25PM +0100, Oliver Hartkopp wrote:
>> Hi Kurt,
>>
> 
>> E.g. why don't you add a j1939_priv pointer to struct dev_rcv_lists when
>> CONFIG_CAN_J1939 is enabled?
> 
> This would allow to lookup a j1939_priv struct from a netdev directly.
> That is a great idea!
> I had not thought about that yet. Partly because I did start out-of-tree :-)
> 
> I'll just go in that direction.
> Btw, It would be a struct j1939_segment * currently.
> I consider
> 	s/j1939_segment/j1939_priv/g 
> if that makes things more clear.


'priv' looks consistent from the af_can point of view, as it is a j1939
private structure attached to the generic CAN per-netdevice structure.

>>
>> Looks like j1939_segment_find() is a frequently used walkthrough function ...
>>
> Your idea of dev_rcv_lists solves that.


That's why i was pointing at this possibility :-)

Regards,
Oliver