From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40147)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UIf3s-000136-03
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:57:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UIf3q-0007pm-8U
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:57:39 -0400
Received: from cantor2.suse.de ([195.135.220.15]:58699 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UIf3q-0007pg-2W
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:57:38 -0400
Message-ID: <514B03BD.1090907@suse.de>
Date: Thu, 21 Mar 2013 13:57:33 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1363633627.git.mst@redhat.com>
In-Reply-To: <cover.1363633627.git.mst@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v9 0/3] DEVICE_DELETED event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Eduardo Habkost <ehabkost@redhat.com>, libvir-list@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

Am 21.03.2013 13:07, schrieb Michael S. Tsirkin:
> Changes from v8:
>     - reorder qom destruction so no need to change unparent=20
>=20
> Changes from v7:
>     - none, v7 was malformed series sent by mistake
>=20
> Changes from v6:
>     - make empty event use data: {}, Markus prefers this
>=20
> Changes from v5:
>     - Emit an empty event on unnamed devices in patch 1/3, as suggested=
 by Markus
>=20
> Changes from v4:
>     - Add extra triggers and extra fields as requested by Markus

Series looks good,

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

>=20
> Changes from v3:
>     - Document that we only emit events for devices with
>       and ID, as suggested by Markus
> Changes from v2:
>     - move event toward the end of device_unparent,
>       so that parents are reported after their children,
>       as suggested by Paolo
> Changes from v1:
>     - move to device_unparent
>     - address comments by Andreas and Eric

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg