From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 2/4] cpuidle / omap4 : use CPUIDLE_FLAG_TIMER_STOP flag Date: Thu, 21 Mar 2013 18:51:53 +0530 Message-ID: <514B0971.8090605@ti.com> References: <1363868494-5503-1-git-send-email-daniel.lezcano@linaro.org> <1363868494-5503-2-git-send-email-daniel.lezcano@linaro.org> <514B04A7.3040707@ti.com> <514B0580.4080408@ti.com> <514B079C.8050002@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:58357 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755781Ab3CUNUW (ORCPT ); Thu, 21 Mar 2013 09:20:22 -0400 In-Reply-To: <514B079C.8050002@linaro.org> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Daniel Lezcano Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, patches@linaro.org, lenb@kernel.org, linus.walleij@linaro.org, rnayak@ti.com, kernel@pengutronix.de, tglx@linutronix.de On Thursday 21 March 2013 06:44 PM, Daniel Lezcano wrote: > On 03/21/2013 02:05 PM, Santosh Shilimkar wrote: >> On Thursday 21 March 2013 06:31 PM, Santosh Shilimkar wrote: >>> $subject >>> s/'cpuidle/omap4' /ARM: CPUidle: OMAP4: >>> >>> On Thursday 21 March 2013 05:51 PM, Daniel Lezcano wrote: >>>> Use the CPUIDLE_FLAG_TIMER_STOP and let the cpuidle framework >>>> to handle the CLOCK_EVT_NOTIFY_BROADCAST_ENTER/EXIT when entering >>>> this state. >>>> >>>> Signed-off-by: Daniel Lezcano >>>> Cc: Len Brown >>>> Cc: Linus Walleij >>>> Cc: Santosh Shilimkar >>>> Cc: Rajendra Nayak >>>> Cc: Sascha Hauer >>>> Cc: Thomas Gleixner >>>> --- >>> Otherwise >>> Akced-by: Santosh Shilimkar >>> >> One more comment for this patch as well as imx and ux500 one. >> >> Remove "#include " since it is not needed >> anymore. > > Actually, it is still needed for: > > omap_setup_broadcast_timer > imx6q_setup_broadcast_timer > ux500_setup_broadcast_timer > Indeed !! > I am preparing another round of patches to move these initialization to > the cpuidle framework but I have to take into account the multiple > drivers support which could be impacted, this is why it is a separated > patchset. > fair enough. Regards, Santosh