From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 21 Mar 2013 10:04:30 -0600 Subject: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000 In-Reply-To: <20130321065553.BC624200547@gemini.denx.de> References: <1363842874-8286-1-git-send-email-swarren@wwwdotorg.org> <20130321065553.BC624200547@gemini.denx.de> Message-ID: <514B2F8E.2090409@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/21/2013 12:55 AM, Wolfgang Denk wrote: > Dear Stephen Warren, > > In message <1363842874-8286-1-git-send-email-swarren@wwwdotorg.org> you wrote: >> Commit b2f3e0e "console: USB: KBD: Fix incorrect autoboot timeout" >> re-wrote the bootdelay timeout loop. However, it hard-coded the value >> that get_delay() was expected to increment in one second, rather than >> calculating it based on CONFIG_SYS_HZ. On systems where SYS_HZ != 1000, >> this caused bootdelay timeout to be incorrect. Fix this. > > Are there any such systems left? I agree with your patch, but if you > know of systems that use incorrect values of CONFIG_SYS_HZ then please > point these out so they can be fixed! > > A system with CONFIG_SYS_HZ != 1000 is _broken_. Then why does the config option still exist; surely it should be removed, or defined somewhere other than the per-board config file?