From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 43/54 v2] ASoC: switch over to use
 snd_soc_register_component() on sh4 ssi
Date: Thu, 21 Mar 2013 10:58:50 -0600
Message-ID: <514B3C4A.7090807@wwwdotorg.org>
References: <87txo96xiu.wl%kuninori.morimoto.gx@renesas.com>
 <8738vpf3qd.wl%kuninori.morimoto.gx@renesas.com>
 <87d2utca54.wl%kuninori.morimoto.gx@renesas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from avon.wwwdotorg.org (avon.wwwdotorg.org [70.85.31.133])
 by alsa0.perex.cz (Postfix) with ESMTP id BB3F0265F8C
 for <alsa-devel@alsa-project.org>; Thu, 21 Mar 2013 17:58:53 +0100 (CET)
In-Reply-To: <87d2utca54.wl%kuninori.morimoto.gx@renesas.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Lars-Peter Clausen <lars@metafoo.de>, Mark Brown <broonie@opensource.wolfsonmicro.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Simon <horms@verge.net.au>, Liam Girdwood <liam.r.girdwood@intel.com>, Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
List-Id: alsa-devel@alsa-project.org

On 03/21/2013 04:36 AM, Kuninori Morimoto wrote:

> diff --git a/sound/soc/sh/ssi.c b/sound/soc/sh/ssi.c

>  static int sh4_soc_dai_probe(struct platform_device *pdev)
>  {
> -	return snd_soc_register_dais(&pdev->dev, sh4_ssi_dai,
> -			ARRAY_SIZE(sh4_ssi_dai));
> +	return snd_soc_register_component(&pdev->dev, &sh4_ssi_component,
> +					  sh4_ssi_dai, ARRAY_SIZE(sh4_ssi_dai));
>  }

ARRAY_SIZE(sh4_ssi_dai) might be 1 or 2 here, based on #ifdef
CONFIG_CPU_SUBTYPE_SH7760. If it's 1, then this change switches the code
from calling snd_soc_register_dais() to snd_soc_register_dai(). This
might be a problem. In practice, perhaps it's won't since the .name
fields in the array entries already are "ssi-dai.0" and "ssi-dai.1", so
perhaps the device ID is already expected not to be appended (because
it's -1 as the device is a singleton)? But, this needs to be checked by
someone familiar with the platform...