From: John Crispin <john@phrozen.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: of: allow au1x00 and rt288x to load from OF
Date: Thu, 21 Mar 2013 17:59:45 +0100 [thread overview]
Message-ID: <514B3C81.5040001@phrozen.org> (raw)
In-Reply-To: <514A153D.8020608@openwrt.org>
On 20/03/13 20:59, John Crispin wrote:
> On 25/01/13 11:50, John Crispin wrote:
>> In order to make serial_8250 loadable via OF on Au1x00 and Ralink
>> WiSoC we need
>> to default the iotype to UPIO_AU.
>>
>> Signed-off-by: John Crispin<blogic@openwrt.org>
>> ---
>> drivers/tty/serial/of_serial.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/tty/serial/of_serial.c
>> b/drivers/tty/serial/of_serial.c
>> index e7cae1c..72e9743 100644
>> --- a/drivers/tty/serial/of_serial.c
>> +++ b/drivers/tty/serial/of_serial.c
>> @@ -97,7 +97,11 @@ static int of_platform_serial_setup(struct
>> platform_device *ofdev,
>> port->regshift = prop;
>>
>> port->irq = irq_of_parse_and_map(np, 0);
>> +#if defined(CONFIG_MIPS_ALCHEMY) || defined(CONFIG_SERIAL_8250_RT288X)
>> + port->iotype = UPIO_AU;
>> +#else
>> port->iotype = UPIO_MEM;
>> +#endif
>> if (of_property_read_u32(np, "reg-io-width",&prop) == 0) {
>> switch (prop) {
>> case 1:
>
> Hi Greg,
>
> i have the impression that this patch got lost somewhere on the way to
> linus. I can see the 1/2 got merged with 3.9-rc1. 2/2 is missing however
>
> Thanks for you help,
>
> John
Hi Greg,
please ignore this patch, I will send a better one without #ifdef'ery
for 3.10. There are 2 other fixes to make the serial work for another
SoC I that will get merged in 3.10. I will put all 3 patches into a new
series
John
next prev parent reply other threads:[~2013-03-21 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 10:50 [PATCH 1/2] serial: ralink: adds support for the serial core found on ralink wisoc John Crispin
2013-01-25 10:50 ` [PATCH 2/2] serial: of: allow au1x00 and rt288x to load from OF John Crispin
2013-01-25 11:44 ` Sergei Shtylyov
2013-01-25 12:40 ` Greg KH
2013-03-20 19:59 ` John Crispin
2013-03-21 16:59 ` John Crispin [this message]
2013-01-25 11:40 ` [PATCH 1/2] serial: ralink: adds support for the serial core found on ralink wisoc Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B3C81.5040001@phrozen.org \
--to=john@phrozen.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.