Re: [PATCH net 3/5] net/mlx4_en: Remove ethtool flow steering rules before releasing QPs

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 03/21/2013 06:55 PM, Or Gerlitz wrote:

> From: Hadar Hen Zion <hadarh@mellanox.com>
>
> Fix the ethtool flow steering rules cleanup to be carried out before
> releasing the RX QPs.
>
> Signed-off-by: Hadar Hen Zion <hadarh@mellanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_netdev.c |   22 +++++++++++-----------
>   1 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> index 995d4b6..f278b10 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> @@ -1637,6 +1637,17 @@ void mlx4_en_stop_port(struct net_device *dev, int detach)
>   	/* Flush multicast filter */
>   	mlx4_SET_MCAST_FLTR(mdev->dev, priv->port, 0, 1, MLX4_MCAST_CONFIG);
>   
> +	/* Remove flow steering rules for the port*/

    Could you add a space before */, despite it was missing before?

WBR, Sergei