All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-networking][danny][PATCH] layer.conf: Use .= for adding to BBPATH and += to BBFILES
Date: Thu, 21 Mar 2013 17:11:11 -0500	[thread overview]
Message-ID: <514B857F.2000400@windriver.com> (raw)
In-Reply-To: <1363902391-29945-1-git-send-email-kergoth@gmail.com>

On 3/21/13 4:46 PM, Christopher Larson wrote:
> From: Andrei Gherzan <andrei.gherzan@windriver.com>
>
> Fixes parsing errors which is appearing after this commit to
> meta-openembedded
>
> http://cgit.openembedded.org/meta-openembedded/commit/?id=3c21a46020bd0816579648f684c41dbd6333583e
>
> This triggers
> exception NameError: name 'base_contains' is not defined
> without this change
>
> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
>   meta-networking/conf/layer.conf | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta-networking/conf/layer.conf b/meta-networking/conf/layer.conf
> index f26a172..1ea2bc2 100644
> --- a/meta-networking/conf/layer.conf
> +++ b/meta-networking/conf/layer.conf
> @@ -1,9 +1,9 @@
>   # We have a conf and classes directory, add to BBPATH
> -BBPATH := "${BBPATH}:${LAYERDIR}"
> +BBPATH .= ":${LAYERDIR}"
>
>   # We have a packages directory, add to BBFILES
> -BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb \
> - ${LAYERDIR}/recipes-*/*/*.bbappend"
> +BBFILES += "${LAYERDIR}/recipes-*/*/*.bb \
> +            ${LAYERDIR}/recipes-*/*/*.bbappend"
>
>   BBFILE_COLLECTIONS += "networking"
>   BBFILE_PATTERN_networking := "^${LAYERDIR}/"
>

Don't those two have to be ":=" so that 'LAYERDIR' is immediately evaluated? 
LAYERDIR changes depending on which layer is currently being processed.

--Mark



  reply	other threads:[~2013-03-21 22:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 21:46 [meta-networking][danny][PATCH] layer.conf: Use .= for adding to BBPATH and += to BBFILES Christopher Larson
2013-03-21 22:11 ` Mark Hatle [this message]
2013-03-21 22:22   ` Chris Larson
2013-03-22 15:24     ` Joe MacDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514B857F.2000400@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.