From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4][resend] arm: at91: add at91sam9n12ek board support
Date: Fri, 22 Mar 2013 12:18:42 +0100 [thread overview]
Message-ID: <514C3E12.3090502@gmail.com> (raw)
In-Reply-To: <1363830777-7927-1-git-send-email-josh.wu@atmel.com>
Dear Josh Wu,
you'd better used v3 for this patch. It is easier to dsitinguish the
patches than and it is allowed to send a single patch in a series in a
newer version.
You could use patman to manage your patches. I have to confess that I
never used it, but I should have a look for it.
On 03/21/2013 02:52 AM, Josh Wu wrote:
> Add support for following features:
> - nand boot, with PMECC 2bit ECC for 512 bytes sector
> - SPI flash boot
> - SD card boot
> - LCD support
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> MAINTAINERS | 3 +
> arch/arm/cpu/arm926ejs/at91/Makefile | 1 +
> arch/arm/cpu/arm926ejs/at91/at91sam9n12_devices.c | 180 ++++++++++++++++
> arch/arm/cpu/arm926ejs/at91/clock.c | 4 +-
> board/atmel/at91sam9n12ek/Makefile | 52 +++++
> board/atmel/at91sam9n12ek/at91sam9n12ek.c | 228 ++++++++++++++++++++
> boards.cfg | 3 +
> include/configs/at91sam9n12ek.h | 232 +++++++++++++++++++++
> 8 files changed, 701 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm/cpu/arm926ejs/at91/at91sam9n12_devices.c
> create mode 100644 board/atmel/at91sam9n12ek/Makefile
> create mode 100644 board/atmel/at91sam9n12ek/at91sam9n12ek.c
> create mode 100644 include/configs/at91sam9n12ek.h
<snip>
> diff --git a/arch/arm/cpu/arm926ejs/at91/clock.c b/arch/arm/cpu/arm926ejs/at91/clock.c
> index f825388..5b4923f 100644
> --- a/arch/arm/cpu/arm926ejs/at91/clock.c
> +++ b/arch/arm/cpu/arm926ejs/at91/clock.c
> @@ -156,7 +156,7 @@ int at91_clock_init(unsigned long main_clock)
> */
> mckr = readl(&pmc->mckr);
> #if defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) \
> - || defined(CONFIG_AT91SAM9X5)
> + || defined(CONFIG_AT91SAM9N12) || defined(CONFIG_AT91SAM9X5)
> /* plla divisor by 2 */
> gd->arch.plla_rate_hz /= (1 << ((mckr & 1 << 12) >> 12));
Can you please re-arrange the patches here and add the 'at91: clock:
remove chip macro for plla_div2' before this patch. So we wouldn't need
to add the macro here and remove it in the next patch.
<snip>
Rest looks good to me.
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2013-03-22 11:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 7:55 [U-Boot] [PATCH v2 0/4] arm: atmel: add at91sam9n12ek board support Josh Wu
2013-03-20 7:55 ` [U-Boot] [PATCH v2 1/4] spi: atmel_spi: using ip version to check whether has wdrbt Josh Wu
2013-03-20 7:55 ` [U-Boot] [PATCH v2 2/4] arm: at91: add at91sam9n12 register definition Josh Wu
2013-03-20 7:55 ` [U-Boot] [PATCH v2 3/4] arm: at91: add at91sam9n12ek board support Josh Wu
2013-03-20 11:14 ` Josh Wu
2013-03-21 1:52 ` [U-Boot] [PATCH v2 3/4][resend] " Josh Wu
2013-03-22 5:29 ` Bo Shen
2013-03-22 6:27 ` Josh Wu
2013-03-22 11:18 ` Andreas Bießmann [this message]
2013-03-20 7:55 ` [U-Boot] [PATCH v2 4/4] at91: clock: remove chip macro for plla div2 Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514C3E12.3090502@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.