All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@tabi.org>
To: Zhicheng Fan <b32736@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/dts: Add qe support for 36bit
Date: Fri, 22 Mar 2013 06:50:45 -0500	[thread overview]
Message-ID: <514C4595.4080706@tabi.org> (raw)
In-Reply-To: <514C054E.4080102@freescale.com>

Zhicheng Fan wrote:
>>
> Hi Timur,
>          you are right ,the QE can not support the 36-bit , I test it on
> the p1025 ,the qe can not work
>          but we need the qe node , becase the dts include the
> fsl/p1021si-post.dtsi
>          that needed, I will send other patch

My suggestion: with a 36-bit device tree, the QE must be disabled.

	qe: qe@fffe80000 {
		/* The QE does not work with 36-bit addressing */
		status = "disabled";
	};

However, on the P102x, there may be a GUTS register that stores the upper 
four bits of the QE's physical address.  Your patch *can* work if you 
*also* set this register to 0xF.  Look for that register.
-- 
Timur Tabi

      reply	other threads:[~2013-03-22 11:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21  9:26 [PATCH] powerpc/dts: Add qe support for 36bit Zhicheng Fan
2013-03-21 18:42 ` Timur Tabi
2013-03-22  7:16   ` Zhicheng Fan
2013-03-22 11:50     ` Timur Tabi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514C4595.4080706@tabi.org \
    --to=timur@tabi.org \
    --cc=b32736@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.