From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: bcm2835: fix delays in bug workaround
Date: Fri, 22 Mar 2013 09:28:52 -0600 [thread overview]
Message-ID: <514C78B4.2010607@wwwdotorg.org> (raw)
In-Reply-To: <20130322074132.11ab8cb2@lilith>
On 03/22/2013 12:41 AM, Albert ARIBAUD wrote:
> Hi Stephen,
>
> On Thu, 21 Mar 2013 22:02:18 -0600, Stephen Warren
> <swarren@wwwdotorg.org> wrote:
>
>> The back-to-back-writes workaround in the BCM2835 MMC driver assumed
>> that get_timer() returned uS. Now that it returns mS, the delay is far
>> too long. Use udelay() directly to avoid this. Dispense with the
>> "last_write" code since we now have no way of recording an absolute
>> time in uS. The difference between two un-averaged tests loading a
>> zImage is 445 mS vs the original 412 mS, so the difference doesn't
>> appear too relevant.
>
> I don't entirely get the 'we have no way of recording an absolute time
> in us': doesn't get_timer_us() precisely provide this absolute us time
> just like 'old' get_timer(base) did? IOW, could you not simply turn
> every get_timer(X) into (get_timer_us()-X)?
Well, I could do that, but that's an internal private API inside
timer.c, not something exported. Should I explicitly export it and allow
the driver to use that?
prev parent reply other threads:[~2013-03-22 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 4:02 [U-Boot] [PATCH] mmc: bcm2835: fix delays in bug workaround Stephen Warren
2013-03-22 6:41 ` Albert ARIBAUD
2013-03-22 15:28 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514C78B4.2010607@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.