From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46150)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UJAjg-0000r2-Mi
	for qemu-devel@nongnu.org; Fri, 22 Mar 2013 18:46:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UJAjf-0001Nu-OI
	for qemu-devel@nongnu.org; Fri, 22 Mar 2013 18:46:56 -0400
Received: from mail-wg0-f43.google.com ([74.125.82.43]:36533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UJAjf-0001Nm-HU
	for qemu-devel@nongnu.org; Fri, 22 Mar 2013 18:46:55 -0400
Received: by mail-wg0-f43.google.com with SMTP id e12so3592513wge.10
	for <qemu-devel@nongnu.org>; Fri, 22 Mar 2013 15:46:54 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <514CDF5A.9020204@redhat.com>
Date: Fri, 22 Mar 2013 23:46:50 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1363974083-28440-1-git-send-email-kwolf@redhat.com>
	<1363974083-28440-7-git-send-email-kwolf@redhat.com>
In-Reply-To: <1363974083-28440-7-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/14] nbd: Keep hostname and port separate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws

Il 22/03/2013 18:41, Kevin Wolf ha scritto:
> +        QemuOpts *opts = qemu_opts_create_nofail(&socket_optslist);
> +
> +        qemu_opt_set(opts, "host", s->inet_addr->host);
> +        qemu_opt_set(opts, "port", s->inet_addr->port);
> +        if (s->inet_addr->has_to) {
> +            qemu_opt_set_number(opts, "to", s->inet_addr->to);
> +        }
> +        if (s->inet_addr->has_ipv4) {
> +            qemu_opt_set_number(opts, "ipv4", s->inet_addr->ipv4);
> +        }
> +        if (s->inet_addr->has_ipv6) {
> +            qemu_opt_set_number(opts, "ipv6", s->inet_addr->ipv6);
> +        }
> +
> +        sock = tcp_socket_outgoing_opts(opts);

Sorry for the late review... You're basically reinventing socket_connect
here.  Would like to clean it up or shall I do it?

Paolo