From: Chris Metcalf <cmetcalf@tilera.com>
To: Henrik Austad <haustad@cisco.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tile: ns2cycles should use __raw_get_cpu_var
Date: Sat, 23 Mar 2013 10:13:41 -0400 [thread overview]
Message-ID: <514DB895.9010201@tilera.com> (raw)
In-Reply-To: <1364023399-26075-1-git-send-email-haustad@cisco.com>
On 3/23/2013 3:23 AM, Henrik Austad wrote:
> + /* we don't have to disable preemptions here as each core has the same
> + * clock-frequency */
Looks OK except the comment is in the wrong style. Kernel multiline comments
/*
* Should look
* like this.
*/
and use full sentences with punctuation. (Also, don't hyphenate clock frequency here.) Thanks!
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2013-03-23 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 17:37 [PATCH] tile: ns2cycles must be called with preempt disabled Henrik Austad
2013-03-22 19:37 ` Chris Metcalf
2013-03-23 7:23 ` [PATCH] tile: ns2cycles should use __raw_get_cpu_var Henrik Austad
2013-03-23 14:13 ` Chris Metcalf [this message]
2013-03-26 7:16 ` Henrik Austad
2013-03-26 13:14 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514DB895.9010201@tilera.com \
--to=cmetcalf@tilera.com \
--cc=haustad@cisco.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.