From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:38906 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753944Ab3CXPuA (ORCPT ); Sun, 24 Mar 2013 11:50:00 -0400 Message-ID: <514F2078.7090807@iki.fi> Date: Sun, 24 Mar 2013 17:49:12 +0200 From: Antti Palosaari MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Hans Verkuil , linux-media@vger.kernel.org, Volokh Konstantin , Pete Eberlein , Hans Verkuil Subject: Re: [REVIEW PATCH 19/42] s2250-loader: use usbv2_cypress_load_firmware References: <1363002380-19825-1-git-send-email-hverkuil@xs4all.nl> <400666fef6bc62079f4ebd7122196c753039aaad.1363000605.git.hans.verkuil@cisco.com> <20130324123924.2451beb9@redhat.com> In-Reply-To: <20130324123924.2451beb9@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 03/24/2013 05:39 PM, Mauro Carvalho Chehab wrote: > Em Mon, 11 Mar 2013 12:45:57 +0100 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> The v2 of this function doesn't do DMA to objects on the stack like >> its predecessor does. >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/staging/media/go7007/Makefile | 4 ++-- >> drivers/staging/media/go7007/s2250-loader.c | 7 ++++--- >> 2 files changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/staging/media/go7007/Makefile b/drivers/staging/media/go7007/Makefile >> index 5bed78b..f9c8e0f 100644 >> --- a/drivers/staging/media/go7007/Makefile >> +++ b/drivers/staging/media/go7007/Makefile >> @@ -11,8 +11,8 @@ s2250-y := s2250-board.o >> #obj-$(CONFIG_VIDEO_SAA7134) += saa7134-go7007.o >> #ccflags-$(CONFIG_VIDEO_SAA7134:m=y) += -Idrivers/media/video/saa7134 -DSAA7134_MPEG_GO7007=3 >> >> -# S2250 needs cypress ezusb loader from dvb-usb >> -ccflags-$(CONFIG_VIDEO_GO7007_USB_S2250_BOARD:m=y) += -Idrivers/media/usb/dvb-usb >> +# S2250 needs cypress ezusb loader from dvb-usb-v2 >> +ccflags-$(CONFIG_VIDEO_GO7007_USB_S2250_BOARD:m=y) += -Idrivers/media/usb/dvb-usb-v2 > > Please don't do it like that. Ok, for now it is in staging, > but once you move it outside it, please move the cypress load firmware > code to drivers/media/common, and do the proper changes for it to be > shared between go7007 and dvb-usb-v2. I agree with Mauro, you could move it to the common as it is nothing DVB USB only related. Acked-by: Antti Palosaari regards Antti -- http://palosaari.fi/