From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Amit Shah <amit.shah@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/19] chardev flow control
Date: Sun, 24 Mar 2013 19:02:13 +0100 [thread overview]
Message-ID: <514F3FA5.2050903@web.de> (raw)
In-Reply-To: <1361224096-21075-1-git-send-email-aliguori@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On 2013-02-18 22:47, Anthony Liguori wrote:
> This series implements an idea from Paolo to introduce flow control
> in the char layer by converting all char backends to use GIOChannels
> internally. Then we can just use the existing IO watch support in glib
> to implement flow control.
>
> This is based on a rebased version of an old series of mine plus a
> number of improvements from Amit Shah.
There is a problem with these changes, maybe just a small bug but I do
not see a simple solution yet:
If an input channel signals readiness but the frontend has no space
(can_read returns 0), the main loop will start busy-waiting, causing
100% CPU load.
It's trivial to reproduce: qemu-system-x86_64 -serial stdio -S, and then
hit a key twice on that console.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2013-03-24 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361224096-21075-1-git-send-email-aliguori@us.ibm.com>
[not found] ` <1361224096-21075-17-git-send-email-aliguori@us.ibm.com>
2013-03-05 17:23 ` [Qemu-devel] [PATCH 16/19] qemu-char: move msmouse registeration to msmouse.c Amit Shah
2013-03-24 18:02 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514F3FA5.2050903@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=amit.shah@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.