From: Chen Gang <gang.chen@asianux.com>
To: apw@canonical.com, Joe Perches <joe@perches.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [Suggestion] scripts/checkpatch.pl: an issue about checking failed for a patch
Date: Mon, 25 Mar 2013 10:48:28 +0800 [thread overview]
Message-ID: <514FBAFC.60503@asianux.com> (raw)
In-Reply-To: <514FB826.9020302@asianux.com>
Hello Maintainers:
when I use ./scripts/checkpatch.pl to check a patch,
it reports a style issue.
but after check, I can not find issue.
(I use "static inline void" instead of "static void inline")
please help check.
thanks.
the related issue is:
--------------------------------------------------------------------------------------------------------------------------------
[root@gchenlinux linux-next]# ./scripts/checkpatch.pl /tmp/0003-include-linux-platform_data-beautify-code-inline-is-.patch
WARNING: line over 80 characters
#22: FILE: include/linux/platform_data/usb-ohci-s3c2410.h:34:
+static inline void s3c2410_usb_report_oc(struct s3c2410_hcd_info *info, int ports)
total: 0 errors, 1 warnings, 8 lines checked
/tmp/0003-include-linux-platform_data-beautify-code-inline-is-.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
--------------------------------------------------------------------------------------------------------------------------------
the related patch is :
("/tmp/0003-include-linux-platform_data-beautify-code-inline-is-.patch")
>From e8be21fd7b7126847a6ddfea5ac002c2ca2ca194 Mon Sep 17 00:00:00 2001
From: Chen Gang <gang.chen@asianux.com>
Date: Mon, 25 Mar 2013 10:25:53 +0800
Subject: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'
better to let 'inline' in front of 'void'
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
include/linux/platform_data/usb-ohci-s3c2410.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/platform_data/usb-ohci-s3c2410.h b/include/linux/platform_data/usb-ohci-s3c2410.h
index 7fa1fbe..cc7554a 100644
--- a/include/linux/platform_data/usb-ohci-s3c2410.h
+++ b/include/linux/platform_data/usb-ohci-s3c2410.h
@@ -31,7 +31,7 @@ struct s3c2410_hcd_info {
void (*report_oc)(struct s3c2410_hcd_info *, int ports);
};
-static void inline s3c2410_usb_report_oc(struct s3c2410_hcd_info *info, int ports)
+static inline void s3c2410_usb_report_oc(struct s3c2410_hcd_info *info, int ports)
{
if (info->report_oc != NULL) {
(info->report_oc)(info, ports);
--
1.7.7.6
next prev parent reply other threads:[~2013-03-25 2:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 2:36 [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void' Chen Gang
2013-03-25 2:48 ` Chen Gang [this message]
2013-03-25 23:32 ` Greg KH
2013-03-26 1:22 ` Chen Gang
2013-03-26 1:48 ` Greg KH
2013-03-26 2:28 ` Chen Gang
2013-03-26 2:47 ` Nicolas Pitre
2013-03-26 3:00 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514FBAFC.60503@asianux.com \
--to=gang.chen@asianux.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.