From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from intranet.asianux.com (intranet.asianux.com [58.214.24.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CC01E2C00B2 for ; Mon, 25 Mar 2013 15:29:17 +1100 (EST) Message-ID: <514FD27B.6050706@asianux.com> Date: Mon, 25 Mar 2013 12:28:43 +0800 From: Chen Gang MIME-Version: 1.0 To: Benjamin Herrenschmidt , "paulus@samba.org" , michael@ellerman.id.au, dhowells@redhat.com, geoff@infradead.org, "sfr@canb.auug.org.au" , Michael Neuling Subject: Re: [PATCH] PowerPC:kernel: section mismatch from smp_release_cpus to __initdata spinning_secondaries References: <51495774.9080809@asianux.com> In-Reply-To: <51495774.9080809@asianux.com> Content-Type: text/plain; charset=UTF-8 Cc: linuxppc-dev@lists.ozlabs.org, "linux-kernel@vger.kernel.org >> \"linux-kernel@vger.kernel.org\"" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello Maintainers: could you help check this patch whether is ok ? thanks. On 2013年03月20日 14:30, Chen Gang wrote: > > the smp_release_cpus is a normal funciton and called in normal environments, > but it calls the __initdata spinning_secondaries. > need modify spinning_secondaries to match smp_release_cpus. > > the related warning: > (the linker report boot_paca.33377, but it should be spinning_secondaries) > > ----------------------------------------------------------------------------- > > WARNING: arch/powerpc/kernel/built-in.o(.text+0x23176): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377 > The function .smp_release_cpus() references > the variable __initdata boot_paca.33377. > This is often because .smp_release_cpus lacks a __initdata > annotation or the annotation of boot_paca.33377 is wrong. > > WARNING: arch/powerpc/kernel/built-in.o(.text+0x231fe): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377 > The function .smp_release_cpus() references > the variable __initdata boot_paca.33377. > This is often because .smp_release_cpus lacks a __initdata > annotation or the annotation of boot_paca.33377 is wrong. > > ----------------------------------------------------------------------------- > > > > Signed-off-by: Chen Gang > --- > arch/powerpc/kernel/setup_64.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c > index 75fbaceb..e8a2f2e 100644 > --- a/arch/powerpc/kernel/setup_64.c > +++ b/arch/powerpc/kernel/setup_64.c > @@ -76,7 +76,7 @@ > #endif > > int boot_cpuid = 0; > -int __initdata spinning_secondaries; > +int spinning_secondaries; > u64 ppc64_pft_size; > > /* Pick defaults since we might want to patch instructions > -- Chen Gang Asianux Corporation