From: Lars-Peter Clausen <lars@metafoo.de>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Mike Frysinger <vapier@gentoo.org>,
uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org
Subject: Re: [uclinux-dist-devel] [PATCH] Blackfin: bf537: rename "CONFIG_ADT7310" and friends
Date: Mon, 25 Mar 2013 12:55:02 +0100 [thread overview]
Message-ID: <51503B16.1050108@metafoo.de> (raw)
In-Reply-To: <1364211831.1390.285.camel@x61.thuisdomein>
On 03/25/2013 12:43 PM, Paul Bolle wrote:
> The Kconfig symbol ADT7310 got removed in commit
> 2b0c856ad9571013db8fc369194b7108dff3c18e ("staging:iio: Consolidate
> adt7310 and adt7410 driver"). That commit did not touch the references
> to CONFIG_ADT7310 and CONFIG_ADT7310_MODULE in the BF537-STAMP code.
> Convert these now, to their ADT7410 equivalents.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Untested. This took a bit of guesswork. I guessed that multiple AD
> drivers can be enabled at the same time in this code. And I also guessed
> that the "adt7310" modalias is still correct.
>
> 1) If this passes testing it could go in stable (3.8.y).
Hi,
Thanks for the patch. Unfortunately this has already changed again for 3.10
since we replaced the IIO adt7410/adt7310 driver with a hwmon driver. So the
new config name is CONFIG_SENSORS_ADT7310.
Thanks,
- Lars
>
> arch/blackfin/mach-bf537/boards/stamp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 95114ed..23bb55d 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -700,7 +700,7 @@ static struct bfin5xx_spi_chip ad7816_spi_chip_info = {
> };
> #endif
>
> -#if defined(CONFIG_ADT7310) || defined(CONFIG_ADT7310_MODULE)
> +#if defined(CONFIG_ADT7410) || defined(CONFIG_ADT7410_MODULE)
> static unsigned long adt7310_platform_data[3] = {
> /* INT bound temperature alarm event. line 1 */
> IRQ_PG4, IRQF_TRIGGER_LOW,
> @@ -1062,7 +1062,7 @@ static struct spi_board_info bfin_spi_board_info[] __initdata = {
> },
> #endif
>
> -#if defined(CONFIG_ADT7310) || defined(CONFIG_ADT7310_MODULE)
> +#if defined(CONFIG_ADT7410) || defined(CONFIG_ADT7410_MODULE)
> {
> .modalias = "adt7310",
> .max_speed_hz = 1000000,
next prev parent reply other threads:[~2013-03-25 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 11:43 [PATCH] Blackfin: bf537: rename "CONFIG_ADT7310" and friends Paul Bolle
2013-03-25 11:55 ` Lars-Peter Clausen [this message]
2013-03-25 12:01 ` [uclinux-dist-devel] " Paul Bolle
2013-03-25 15:22 ` Guenter Roeck
2013-03-25 15:45 ` Lars-Peter Clausen
2014-02-13 9:57 ` Paul Bolle
2014-02-13 10:31 ` Paul Bolle
2014-02-13 16:29 ` Guenter Roeck
2014-02-13 17:03 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51503B16.1050108@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.