All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Orit Wasserman <owasserm@redhat.com>,
	quintela@redhat.com, chegu vinod <chegu_vinod@hp.com>,
	qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy
Date: Mon, 25 Mar 2013 11:18:35 -0400	[thread overview]
Message-ID: <51506ACB.1090506@linux.vnet.ibm.com> (raw)
In-Reply-To: <1785134388.13096135.1364216711974.JavaMail.root@redhat.com>

Right, the header's not used - but, are we certain that 
put_buffer_copy() will *always* be used for RAM in the future?

- Michael

On 03/25/2013 09:05 AM, Paolo Bonzini wrote:
>
> ----- Messaggio originale -----
>> Da: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
>> A: "Orit Wasserman" <owasserm@redhat.com>
>> Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com, "chegu vinod" <chegu_vinod@hp.com>,
>> quintela@redhat.com
>> Inviato: Sabato, 23 marzo 2013 17:27:49
>> Oggetto: Re: [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy
>>
>> Can you add a "flag" or something to indicate that the iov pointer
>> belongs to RAM and not to device state?
>>
>> That way, I could re-use this code for RDMA - if I see this flag, I
>> will know to send to RDMA.....
> I am not sure you can, because the function will be preceded by
> a qemu_put_be64 to store the header.  That header is not sent in
> the RDMA case, isn't it?
>
> Paolo
>

  reply	other threads:[~2013-03-25 15:21 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21  9:09 [Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages Orit Wasserman
2013-03-21  9:09 ` [Qemu-devel] [RFC 01/12] Add iov_writev to use writev to send iovec (also for files) Orit Wasserman
2013-03-21  9:23   ` Paolo Bonzini
2013-03-21  9:09 ` [Qemu-devel] [RFC 02/12] Add QemuFileWritevBuffer QemuFileOps Orit Wasserman
2013-03-21  9:09 ` [Qemu-devel] [RFC 03/12] Add socket_writev_buffer function Orit Wasserman
2013-03-21  9:18   ` Paolo Bonzini
2013-03-21  9:47     ` Orit Wasserman
2013-03-21  9:47       ` Paolo Bonzini
2013-03-21 10:17         ` Orit Wasserman
2013-03-21  9:09 ` [Qemu-devel] [RFC 04/12] Add stdio_writev_buffer function Orit Wasserman
2013-03-21  9:28   ` Paolo Bonzini
2013-03-21  9:09 ` [Qemu-devel] [RFC 05/12] Add block_writev_buffer function Orit Wasserman
2013-03-21  9:09 ` [Qemu-devel] [RFC 06/12] Update bytes_xfer in qemu_put_byte Orit Wasserman
2013-03-21  9:09 ` [Qemu-devel] [RFC 07/12] Store the data to send also in iovec Orit Wasserman
2013-03-21  9:56   ` Paolo Bonzini
2013-03-21 11:10     ` Orit Wasserman
2013-03-21 11:14       ` Michael S. Tsirkin
2013-03-21 12:50         ` Orit Wasserman
2013-03-21 13:00           ` Paolo Bonzini
2013-03-21  9:09 ` [Qemu-devel] [RFC 08/12] Use writev ops instead of put_buffer ops Orit Wasserman
2013-03-21  9:09 ` [Qemu-devel] [RFC 09/12] More optimized qemu_put_be64/32/16 Orit Wasserman
2013-03-21  9:09 ` [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy Orit Wasserman
2013-03-21  9:25   ` Paolo Bonzini
2013-03-23 16:27   ` Michael R. Hines
2013-03-25  8:11     ` Orit Wasserman
2013-03-25 13:05     ` Paolo Bonzini
2013-03-25 15:18       ` Michael R. Hines [this message]
2013-03-25 15:59         ` Paolo Bonzini
2013-03-21  9:09 ` [Qemu-devel] [RFC 11/12] Use qemu_put_buffer_no_copy for guest memory pages Orit Wasserman
2013-03-21  9:09 ` [Qemu-devel] [RFC 12/12] Bye Bye put_buffer Orit Wasserman
2013-03-21  9:29 ` [Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages Paolo Bonzini
2013-03-21 10:05   ` Orit Wasserman
2013-03-21  9:48 ` Michael S. Tsirkin
2013-03-21  9:53   ` Paolo Bonzini
2013-03-21 11:09     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51506ACB.1090506@linux.vnet.ibm.com \
    --to=mrhines@linux.vnet.ibm.com \
    --cc=chegu_vinod@hp.com \
    --cc=mst@redhat.com \
    --cc=owasserm@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.