From: Zhang Yanfei <zhangyanfei.yes@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH 2/2] kexec: Use err() instead of fprintf()
Date: Mon, 25 Mar 2013 23:21:51 +0800 [thread overview]
Message-ID: <51506B8F.2090106@gmail.com> (raw)
In-Reply-To: <20130320132145.GK16436@verge.net.au>
于 2013年03月20日 21:21, Simon Horman 写道:
> On Wed, Mar 20, 2013 at 09:17:51PM +0800, Zhang Yanfei wrote:
>> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
>>
>> Since we have the err() interface, so replace the error printing
>> function with err().
>
> This patch introduces a lot of code changes and I'm not entirely
> sure that I see the benefit.
Sorry for the long patch.
I just wanted to use a simpler error displaying function instead of
fprintf(stderr, ...). Just like we use die() or dbgprintf. If you
think this is unnecessary, just ignore the patch please.
Thanks
Zhang
>
>> Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
>> ---
>> kexec/arch/arm/kexec-arm.c | 3 +-
>> kexec/arch/arm/kexec-zImage-arm.c | 18 ++++-----
>> kexec/arch/i386/crashdump-x86.c | 37 ++++++++---------
>> kexec/arch/i386/kexec-bzImage.c | 18 ++++----
>> kexec/arch/i386/kexec-elf-x86.c | 4 +-
>> kexec/arch/i386/kexec-multiboot-x86.c | 11 ++---
>> kexec/arch/i386/kexec-nbi.c | 14 +++---
>> kexec/arch/i386/kexec-x86-common.c | 27 ++++++-------
>> kexec/arch/i386/kexec-x86.c | 9 +---
>> kexec/arch/i386/x86-linux-setup.c | 19 ++++-----
>> kexec/arch/ia64/crashdump-ia64.c | 5 +-
>> kexec/arch/ia64/kexec-elf-ia64.c | 12 +++---
>> kexec/arch/ia64/kexec-ia64.c | 3 +-
>> kexec/arch/mips/crashdump-mips.c | 11 ++---
>> kexec/arch/mips/kexec-elf-mips.c | 2 +-
>> kexec/arch/mips/kexec-mips.c | 4 +-
>> kexec/arch/ppc/crashdump-powerpc.c | 5 +-
>> kexec/arch/ppc/fixup_dtb.c | 3 +-
>> kexec/arch/ppc/kexec-dol-ppc.c | 14 +++----
>> kexec/arch/ppc/kexec-elf-ppc.c | 4 +-
>> kexec/arch/ppc/kexec-ppc.c | 36 ++++++++--------
>> kexec/arch/ppc/kexec-uImage-ppc.c | 2 +-
>> kexec/arch/ppc64/crashdump-ppc64.c | 10 ++---
>> kexec/arch/ppc64/fs2dt.c | 2 +-
>> kexec/arch/ppc64/kexec-elf-ppc64.c | 17 ++++----
>> kexec/arch/ppc64/kexec-ppc64.c | 6 +-
>> kexec/arch/ppc64/kexec-zImage-ppc64.c | 18 +++-----
>> kexec/arch/s390/kexec-image.c | 4 +-
>> kexec/arch/s390/kexec-s390.c | 2 +-
>> kexec/arch/sh/kexec-sh.c | 2 +-
>> kexec/arch/x86_64/kexec-bzImage64.c | 16 ++++----
>> kexec/arch/x86_64/kexec-elf-x86_64.c | 6 +-
>> kexec/arch/x86_64/kexec-x86_64.c | 5 +-
>> kexec/crashdump-xen.c | 8 ++--
>> kexec/firmware_memmap.c | 12 ++---
>> kexec/fs2dt.c | 2 +-
>> kexec/kernel_version.c | 17 +++-----
>> kexec/kexec-elf-exec.c | 8 ++--
>> kexec/kexec-elf-rel.c | 10 ++--
>> kexec/kexec-elf.c | 70 ++++++++++++++++-----------------
>> kexec/kexec.c | 64 ++++++++++++------------------
>> kexec/phys_arch.c | 6 +--
>> kexec/zlib.c | 2 +-
>> 43 files changed, 249 insertions(+), 299 deletions(-)
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-03-25 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 13:15 [PATCH 1/2] kexec: Add new interface for printing error messages Zhang Yanfei
2013-03-20 13:17 ` [PATCH 2/2] kexec: Use err() instead of fprintf() Zhang Yanfei
2013-03-20 13:21 ` Simon Horman
2013-03-25 15:21 ` Zhang Yanfei [this message]
2013-03-27 12:43 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51506B8F.2090106@gmail.com \
--to=zhangyanfei.yes@gmail.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.