Re: [Qemu-devel] [PATCH v2] New QMP command query-cpu-max and HMP command cpu_max

[Michal Novotny <minovotn@redhat.com>]

On 03/25/2013 05:13 PM, Luiz Capitulino wrote:
> On Mon, 25 Mar 2013 16:58:50 +0100
> Michal Novotny <minovotn@redhat.com> wrote:
>
>> These commands return the maximum number of CPUs supported by the
> /These commands/This command


I meant both of them - both QMP (query-cpu-max) one HMP (cpu_max) one.


>
>> currently running emulator instance, as defined in its QEMUMachine
>> struct.
>>
>> Signed-off-by: Michal Novotny <minovotn@redhat.com>
>> ---
>>  hmp-commands.hx  | 14 ++++++++++++++
>>  hmp.c            | 15 +++++++++++++++
>>  hmp.h            |  1 +
>>  qapi-schema.json | 11 +++++++++++
>>  qmp-commands.hx  | 22 ++++++++++++++++++++++
>>  vl.c             |  5 +++++
>>  6 files changed, 68 insertions(+)
>>
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index df44906..c976459 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -690,6 +690,20 @@ Set the default CPU.
>>  ETEXI
>>  
>>      {
>> +        .name       = "cpu_max",
>> +        .args_type  = "",
>> +        .params     = "",
>> +        .help       = "Get maximum number of VCPUs supported by machine",
>> +        .mhandler.cmd = hmp_query_cpu_max,
>> +    },
>> +
>> +STEXI
>> +@item cpu_max
>> +@findex cpu_max
>> +Returns the number of CPUs supported by the machine being emulated.
>> +ETEXI
>> +
>> +    {
>>          .name       = "mouse_move",
>>          .args_type  = "dx_str:s,dy_str:s,dz_str:s?",
>>          .params     = "dx dy [dz]",
>> diff --git a/hmp.c b/hmp.c
>> index b0a861c..6d5674f 100644
>> --- a/hmp.c
>> +++ b/hmp.c
>> @@ -748,6 +748,21 @@ void hmp_ringbuf_read(Monitor *mon, const QDict *qdict)
>>      g_free(data);
>>  }
>>  
>> +void hmp_query_cpu_max(Monitor *mon, const QDict *qdict)
>> +{
>> +    int cpu_max;
>> +    Error *errp = NULL;
>> +
>> +    cpu_max = qmp_query_cpu_max(&errp);
>> +    if (errp) {
>> +        monitor_printf(mon, "%s\n", error_get_pretty(errp));
>> +        error_free(errp);
>> +        return;
>> +    }
> Sorry for not noticing this before, but you can pass NULL to
> qmp_query_cpu_max(), as it never fails.


Ok, I just went according to the docs and there was no mention about
it's possible to pass NULL. I don't know what magic qemu does with that
one so I rather don't pass NULL. However, respin necessary?

Michal

-- 
Michal Novotny <minovotn@redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings | php-virt-control.org