From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKHWJ-0004w3-37 for qemu-devel@nongnu.org; Mon, 25 Mar 2013 20:13:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKHWC-00054q-RY for qemu-devel@nongnu.org; Mon, 25 Mar 2013 20:13:43 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:59784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKHWC-00054m-Kj for qemu-devel@nongnu.org; Mon, 25 Mar 2013 20:13:36 -0400 Received: by mail-pa0-f46.google.com with SMTP id wp1so1291596pac.5 for ; Mon, 25 Mar 2013 17:13:36 -0700 (PDT) Sender: Richard Henderson Message-ID: <5150E82C.5080200@twiddle.net> Date: Mon, 25 Mar 2013 17:13:32 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1E58A03D-3CD1-495E-840E-9DB7574F3638@suse.de> In-Reply-To: <1E58A03D-3CD1-495E-840E-9DB7574F3638@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] s390 tcg breakage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: " qemu-devel" On 2013-03-25 06:19, Alexander Graf wrote: > This is because lgfi leaves the register negative, but iihl doesn't replace the upper 16 bits, only [48..32]. > > The patch below fixes it for me, but I'm sure you can come up with something cleaner, better and working on non-ext-imm machines :). Oops, yes. I've posted a patch that addresses the problem for real. r~