All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: vikas.chaudhary@qlogic.com
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
	lalit.chandivade@qlogic.com, ravi.anand@qlogic.com,
	poornima.vonti@qlogic.com, manish.rangankar@qlogic.com,
	Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
Subject: Re: [PATCH 1/3] scsi_transport_iscsi: Declare portal type string macros for generic use
Date: Mon, 25 Mar 2013 20:37:55 -0500	[thread overview]
Message-ID: <5150FBF3.5050503@cs.wisc.edu> (raw)
In-Reply-To: <1364213313-17754-1-git-send-email-vikas.chaudhary@qlogic.com>

Patches 1 - 3 look ok to me.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>

On 03/25/2013 07:08 AM, vikas.chaudhary@qlogic.com wrote:
> From: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
> 
> Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
> ---
>  include/scsi/iscsi_if.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h
> index f1b0183..fe7f06c 100644
> --- a/include/scsi/iscsi_if.h
> +++ b/include/scsi/iscsi_if.h
> @@ -504,6 +504,10 @@ enum iscsi_host_param {
>  	ISCSI_HOST_PARAM_MAX,
>  };
>  
> +/* portal type */
> +#define PORTAL_TYPE_IPV4	"ipv4"
> +#define PORTAL_TYPE_IPV6	"ipv6"
> +
>  /* iSCSI Flash Target params */
>  enum iscsi_flashnode_param {
>  	ISCSI_FLASHNODE_IS_FW_ASSIGNED_IPV6,
> 


  parent reply	other threads:[~2013-03-26  1:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 12:08 [PATCH 1/3] scsi_transport_iscsi: Declare portal type string macros for generic use vikas.chaudhary
2013-03-25 12:08 ` [PATCH 2/3] qla4xxx: Replace dev type macros with generic portal type macros vikas.chaudhary
2013-03-26  1:37 ` Mike Christie [this message]
2013-04-11 22:17   ` [PATCH 1/3] scsi_transport_iscsi: Declare portal type string macros for generic use James Bottomley
2013-04-11 22:20     ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5150FBF3.5050503@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=adheer.chandravanshi@qlogic.com \
    --cc=jbottomley@parallels.com \
    --cc=lalit.chandivade@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manish.rangankar@qlogic.com \
    --cc=poornima.vonti@qlogic.com \
    --cc=ravi.anand@qlogic.com \
    --cc=vikas.chaudhary@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.