Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On 2013-03-25 21:30, Gerd Hoffmann wrote:
> On 03/25/13 14:56, Igor Mitsyanko wrote:
>> On 03/25/2013 02:37 PM, Gerd Hoffmann wrote:
>>>
>>>>    Hi,
>>>>
>>>>  [5425.580115] displaysurface_create_from surface=0x7ff315d3df40,
>>>>> 800x600, bpp 16, bswap 0 [5425.580257] displaysurface_free
>>>>> surface=0x7ff3158c33b0
>>>>>
>>>>
>>>> This is vga=0x314
>>>>
>>>> Looks like we have some funky interaction between vga and vmware.
>>>>
>>>> I'll go dig.  Meanwhile you can try vga=0x315 (800x600x24) or
>>>> vga=normal (textmode), that has a high chance to workaround this.
>>>>
>>>> cheers,
>>>>    Gerd
>>>>
>>>
>>>
>>
>>  Couldn't it be because wred, wgreen and wblue were removed? It seems like
>> it was a workaround for some pre-existing problem, is it ok that you
>> removed them but left depth and bypp intact?
> 
> No, it is not, and yes, this is where the inconsistency comes from.  We
> read wred+wgreen+wblue directly from the surface whereas depth is cached
> in the vmware vga state struct.  Patch attached.  Not fully tested yet.

Unfortunately, this doesn't change the picture (except for the expected
"vmsvga_value_read: Bad register 1c"). The 0x315 workaround does indeed
work.

Jan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]