From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v4 09/21] modetest: Allow specifying plane position Date: Tue, 26 Mar 2013 14:14:14 +0530 Message-ID: <51515FDE.6080901@ti.com> References: <1363704962-14077-1-git-send-email-laurent.pinchart@ideasonboard.com> <1363704962-14077-10-git-send-email-laurent.pinchart@ideasonboard.com> <514FEB4B.90700@ti.com> <2279969.E0Cttns2Pm@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTP id BCE60E5CE0 for ; Tue, 26 Mar 2013 01:45:05 -0700 (PDT) In-Reply-To: <2279969.E0Cttns2Pm@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tuesday 26 March 2013 04:11 AM, Laurent Pinchart wrote: > Hi Archit, > > On Monday 25 March 2013 11:44:35 Archit Taneja wrote: >> Hi Laurent, >> >> On Tuesday 19 March 2013 08:25 PM, Laurent Pinchart wrote: >>> Extend the -P option to allow specifying the plane x and y offsets. The >>> position is optional, if not specified the plane will be positioned at >>> the center of the screen as before. >> >> Thanks for this series. I tested the patches with a Panda ES board. >> >> I was facing issues with the plane position though, when I execute this >> on the command line: >> >> ./modetest -s 12:1440x900 -P 6:(0,0)/300x200 >> >> I get a syntax error by bash saying it doesn't expect "(". I guess there >> are ways around to get over this, > > I use > > ./modetest -s 12:1440x900 -P '6:(0,0)/300x200' > >> but I was wondering if we could get rid of the braces all together to keep >> it simple? The "/" character could be used to figure out whether the user >> has also mentioned position or not. > > It makes parsing the option a bit more complex, but I can do that if you think > it's better. I think it's fine. After googling a bit on the syntax error issue, I thought that putting the command in a script file was the only option, but your method above is convenient enough. Thanks, Archit