Re: [Qemu-devel] [PATCH v3] New QMP command query-cpu-max and HMP command cpu_max

[Michal Novotny <minovotn@redhat.com>]

On 03/25/2013 07:37 PM, Luiz Capitulino wrote:
> On Mon, 25 Mar 2013 17:31:33 +0100
> Michal Novotny <minovotn@redhat.com> wrote:
>
>> These commands return the maximum number of CPUs supported by the
>> currently running emulator instance, as defined in its QEMUMachine
>> struct.
> I've applied this patch to the QMP tree, but with one change (see below).
>
>> Signed-off-by: Michal Novotny <minovotn@redhat.com>
>> ---
>>  hmp-commands.hx  | 14 ++++++++++++++
>>  hmp.c            |  8 ++++++++
>>  hmp.h            |  1 +
>>  qapi-schema.json | 11 +++++++++++
>>  qmp-commands.hx  | 22 ++++++++++++++++++++++
>>  vl.c             |  5 +++++
>>  6 files changed, 61 insertions(+)
>>
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index df44906..c976459 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -690,6 +690,20 @@ Set the default CPU.
>>  ETEXI
>>  
>>      {
>> +        .name       = "cpu_max",
>> +        .args_type  = "",
>> +        .params     = "",
>> +        .help       = "Get maximum number of VCPUs supported by machine",
>> +        .mhandler.cmd = hmp_query_cpu_max,
>> +    },
>> +
>> +STEXI
>> +@item cpu_max
>> +@findex cpu_max
>> +Returns the number of CPUs supported by the machine being emulated.
>> +ETEXI
> What you really want is an info command, like 'info cpu_max'. As I didn't
> spot this in my first review (looks like I'm still sleeping, although it's
> afternoon) I've made that change myself and applied the patch to the qmp tree.
>
> Now, if you disagree I can drop it and we discuss the matter :)

I'm fine with that :-)

Michal


-- 
Michal Novotny <minovotn@redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings | php-virt-control.org