From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] ACPI/APEI: revert "accept validly sized
 ERST on Intel systems only for now"
Date: Tue, 26 Mar 2013 14:24:45 +0000
Message-ID: <5151AFAD.9030304@citrix.com>
References: <515177CD02000078000C875D@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <515177CD02000078000C875D@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 26/03/2013 09:26, Jan Beulich wrote:
> With the recent two fixes to ERST handling, this should no longer be
> necessary.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

There are still no failures from our regression testing, so a tentative

Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/drivers/acpi/apei/erst.c
> +++ b/xen/drivers/acpi/apei/erst.c
> @@ -738,19 +738,6 @@ static int __init erst_check_table(struc
>  
>  	switch (erst_tab->header_length) {
>  	case sizeof(*erst_tab) - sizeof(erst_tab->header):
> -#ifdef CONFIG_X86
> -		/* XXX
> -		 * While the rest of the ERST code appears to work on Intel
> -		 * systems with properly sized tables, various AMD systems
> -		 * appear to get hung (at boot time) by allowing this. Until
> -		 * someone with access to suitable hardware can debug this,
> -		 * disable the rest of the code by considering this case
> -		 * invalid.
> -		 */
> -		if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
> -			return -EINVAL;
> -		/* fall through */
> -#endif
>  	/*
>  	 * While invalid per specification, there are (early?) systems
>  	 * indicating the full header size here, so accept that value too.
>
>
>