From: Jim Baxter <jim_baxter@mentor.com>
To: unlisted-recipients:; (no To-header on input)
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/1] net: fec: TX Buffer incorrectly initialized
Date: Tue, 26 Mar 2013 16:00:55 +0000 [thread overview]
Message-ID: <5151C637.9010403@mentor.com> (raw)
In-Reply-To: <1364312644.1716.33.camel@edumazet-glaptop>
The field is the extended status control for the FEC network device, the
values written to it are used to set the hardware transmit and receive
state.
*From:* Eric Dumazet (eric.dumazet@gmail.com) *Sent:* Tue, 26 Mar 2013
08:44:04 -0700 *To:* jim_baxter@mentor.com *Cc:* davem@davemloft.net,
Frank.Li@freescale.com, fabio.estevam@freescale.com,
netdev@vger.kernel.org *Subject:* Re: [PATCH net-next 1/1] net: fec: TX
Buffer incorrectly initialized
> On Tue, 2013-03-26 at 15:25 +0000, Jim Baxter wrote:
>> The TX Buffer in fec_enet_alloc_buffers was being initialized
>> with the receive register define BD_ENET_RX_INT instead of
>> the transmit register define BD_ENET_TX_INT
>>
>> Signed-off-by: Jim Baxter <jim_baxter@mentor.com>
>> ---
>> drivers/net/ethernet/freescale/fec_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
>> index 3eb608f..2b78a1e 100644
>> --- a/drivers/net/ethernet/freescale/fec_main.c
>> +++ b/drivers/net/ethernet/freescale/fec_main.c
>> @@ -1391,7 +1391,7 @@ static int fec_enet_alloc_buffers(struct net_device *ndev)
>>
>> if (fep->bufdesc_ex) {
>> struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp;
>> - ebdp->cbd_esc = BD_ENET_RX_INT;
>> + ebdp->cbd_esc = BD_ENET_TX_INT;
>> }
>>
>> bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex);
>
> I am curious. What is the point having cbd_esc ?
>
> Its a written only field.
>
>
>
next prev parent reply other threads:[~2013-03-26 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 15:25 [PATCH net-next 1/1] net: fec: TX Buffer incorrectly initialized Jim Baxter
2013-03-26 15:44 ` Eric Dumazet
2013-03-26 16:00 ` Jim Baxter [this message]
2013-03-26 16:08 ` Eric Dumazet
2013-03-26 16:12 ` David Miller
2013-03-26 16:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5151C637.9010403@mentor.com \
--to=jim_baxter@mentor.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.