From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKWrT-0003pH-Dv for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKWrO-0004gw-Dm for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:36:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKWrO-0004gC-57 for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:36:30 -0400 Message-ID: <5151CE32.8050203@redhat.com> Date: Tue, 26 Mar 2013 10:34:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1364314072-2474-1-git-send-email-stefanha@redhat.com> <1364314072-2474-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1364314072-2474-3-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2FUKFARVWAJEWPCJMFQEP" Subject: Re: [Qemu-devel] [PATCH 2/4] qemu-socket: set passed fd non-blocking in socket_connect() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , david.pravec@nethost.cz, Juan Quintela , mprivozn@redhat.com, Corey Bryant , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2FUKFARVWAJEWPCJMFQEP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/26/2013 10:07 AM, Stefan Hajnoczi wrote: > socket_connect() sets non-blocking on TCP or UNIX domain sockets if a > callback function is passed. Do the same for file descriptor passing, > otherwise we could unexpectedly be using a blocking file descriptor. >=20 > Signed-off-by: Stefan Hajnoczi > --- > util/qemu-sockets.c | 1 + > 1 file changed, 1 insertion(+) >=20 Reviewed-by: Eric Blake > diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c > index b6b78f5..298f6f2 100644 > --- a/util/qemu-sockets.c > +++ b/util/qemu-sockets.c > @@ -910,6 +910,7 @@ int socket_connect(SocketAddress *addr, Error **err= p, > case SOCKET_ADDRESS_KIND_FD: > fd =3D monitor_get_fd(cur_mon, addr->fd->str, errp); > if (callback) { > + socket_set_nonblock(fd); > callback(fd, opaque); > } > break; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2FUKFARVWAJEWPCJMFQEP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRUc4yAAoJEKeha0olJ0NqgggIAK/ItJQb03PGmyughKpRTFSt f/D3a+WrQBn32gasUtVNhVHVEux169pFLCfb5XU5HM8hmPM1Tu7SJpTvWbxxDOe5 cwunZUarkP8jL7SD4E6g6n2NhFW+hHdkfmGXMW8drcq0qZPJfMf/WYfAxKGT+BQR Ur/fewCi36NCtX2bU141fkeja7GdXapyDLv1378BZrPefOoDR9WIdndJOwFzbTKg KWGBSlZwcK1+y1RUkznat5Xc4n814wJSTORnyB6bp+nwt0mpe7YCw4PrOQkNCmPh j/WiKm6nw4pdgCEofAOnBgu4fSIVMLEKVkhBvbmUEhuTPL7WaLeyp0Lo2LyqjIY= =PXdE -----END PGP SIGNATURE----- ------enig2FUKFARVWAJEWPCJMFQEP--