All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation
Date: Wed, 27 Mar 2013 14:39:44 +0900	[thread overview]
Message-ID: <51528620.4010901@samsung.com> (raw)
In-Reply-To: <CAPbRUm==XZQWB8s+quF77B7J4ZT-ycNezpDzRXPf72utiqgVrQ@mail.gmail.com>

Dear Amar,

On 27/03/13 14:18, Amarendra Reddy wrote:
> Dear Minkyu,
> 

please don't top posting.

> The definition of "RX_WMARK" is present in "[PATCH V7 04/10] EXYNOS5: DWMMC: Added FDT support for DWMMC".
> 
> Here is the URL, http://www.mail-archive.com/u-boot at lists.denx.de/msg107515.html

Then please move it to this patch.

> 
> Thanks & Regards
> Amarendra Reddy
> 
> On 27 March 2013 10:33, Minkyu Kang <mk7.kang at samsung.com <mailto:mk7.kang@samsung.com>> wrote:
> 
>     Dear Amar,
> 
>     On 05/12/12 22:31, Amar wrote:
>     > The current implementation of fifo size computation was giving improper
>     > values for eMMC channel. Modified the computation as per user manual.
>     >
>     > Signed-off-by: Amarendra Reddy <amarendra.xt at samsung.com <mailto:amarendra.xt@samsung.com>>
>     > ---
>     >  drivers/mmc/dw_mmc.c |    2 ++
>     >  1 files changed, 2 insertions(+), 0 deletions(-)
>     >
>     > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
>     > index 4070d4e..62dc152 100644
>     > --- a/drivers/mmc/dw_mmc.c
>     > +++ b/drivers/mmc/dw_mmc.c
>     > @@ -332,6 +332,8 @@ static int dwmci_init(struct mmc *mmc)
>     >       dwmci_writel(host, DWMCI_BMOD, 1);
>     >
>     >       fifo_size = dwmci_readl(host, DWMCI_FIFOTH);
>     > +     fifo_size = ((fifo_size & RX_WMARK(0xFFF)) >> 16) + 1;
> 
>     The definition of RX_WMARK is missing.
> 
>     > +
>     >       if (host->fifoth_val)
>     >               fifoth_val = host->fifoth_val;
>     >       else
>     >
> 
>     Thanks,
>     Minkyu Kang.
>     _______________________________________________
>     U-Boot mailing list
>     U-Boot at lists.denx.de <mailto:U-Boot@lists.denx.de>
>     http://lists.denx.de/mailman/listinfo/u-boot
> 
> 

Thanks,
Minkyu Kang.

  reply	other threads:[~2013-03-27  5:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 13:31 [U-Boot] [PATCH 0/4] EXYNOS5: Enable dwmmc Amar
2012-12-05 13:31 ` [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation Amar
2012-12-06  3:59   ` Jaehoon Chung
2012-12-08 19:49     ` Simon Glass
2012-12-10  2:21       ` Jaehoon Chung
2012-12-10  6:09         ` Amarendra Reddy
2013-03-27  5:03   ` Minkyu Kang
2013-03-27  5:18     ` Amarendra Reddy
2013-03-27  5:39       ` Minkyu Kang [this message]
2012-12-05 13:31 ` [U-Boot] [PATCH 2/4] MMC: EXYNOS: Added call back function for clock get Amar
2012-12-06  4:03   ` Jaehoon Chung
2013-03-27  5:14   ` Minkyu Kang
2013-03-27  5:38     ` Amarendra Reddy
2013-03-27  7:40       ` Minkyu Kang
2013-03-27  8:01         ` Amarendra Reddy
2012-12-05 13:31 ` [U-Boot] [PATCH 3/4] EXYNOS: CLOCK: Initialised the local variable Amar
2012-12-06  4:04   ` Jaehoon Chung
2012-12-05 13:31 ` [U-Boot] [PATCH 4/4] SMDK5250: Initialise and enable dwmmc channels Amar
2012-12-06  4:08   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51528620.4010901@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.