From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKo8y-000699-IV for qemu-devel@nongnu.org; Wed, 27 Mar 2013 07:03:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKo8t-0000Ou-TI for qemu-devel@nongnu.org; Wed, 27 Mar 2013 07:03:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42341 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKo8t-0000Od-Js for qemu-devel@nongnu.org; Wed, 27 Mar 2013 07:03:43 -0400 Message-ID: <5152D20B.5090101@suse.de> Date: Wed, 27 Mar 2013 12:03:39 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <514C1560.1020406@jp.fujitsu.com> <514C1656.8020503@jp.fujitsu.com> In-Reply-To: <514C1656.8020503@jp.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/5] qdev: add qdev_{create, free} tracepoints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kazuya Saito Cc: Paolo Bonzini , qemu-devel@nongnu.org Am 22.03.2013 09:29, schrieb Kazuya Saito: > This patch adds tracepoints at creating and removing virtual > devices. It is useful for investigation of trouble related to virtual > devices. >=20 > Signed-off-by: Kazuya Saito I would prefer not to do this. I had previously posted a patch to remove qdev_free() in favor of using the QOM function object_unparent() directly, which adding stuff to qdev_free() would interfere with. And you should rather add a tracepoint to object_new() or better to object_initialize() than into the legacy qdev_create() - which doesn't cover qdev_try_create() btw. Either way, adding new tracepoints with the legacy "qdev" in the name is ugly. Regards, Andreas P.S. Your patches arrived in HTML format, please check your workflow. > --- > hw/qdev.c | 3 +++ > trace-events | 4 ++++ > 2 files changed, 7 insertions(+), 0 deletions(-) >=20 > diff --git a/hw/qdev.c b/hw/qdev.c > index 0b20280..0fda23e 100644 > --- a/hw/qdev.c > +++ b/hw/qdev.c > @@ -30,6 +30,7 @@ > #include "qapi/error.h" > #include "qapi/qmp/qerror.h" > #include "qapi/visitor.h" > +#include "trace.h" >=20 > int qdev_hotplug =3D 0; > static bool qdev_hot_added =3D false; > @@ -124,6 +125,7 @@ DeviceState *qdev_create(BusState *bus, const char = *name) > } > } >=20 > + trace_qdev_create(dev, dev->parent_bus); > return dev; > } >=20 > @@ -268,6 +270,7 @@ void qdev_init_nofail(DeviceState *dev) > /* Unlink device from bus and free the structure. */ > void qdev_free(DeviceState *dev) > { > + trace_qdev_free(dev, dev->parent_bus); > object_unparent(OBJECT(dev)); > } >=20 > diff --git a/trace-events b/trace-events > index c691ce4..235b978 100644 > --- a/trace-events > +++ b/trace-events > @@ -1102,3 +1102,7 @@ kvm_ioctl(int type) "type %d" > kvm_vm_ioctl(int type) "type %d" > kvm_vcpu_ioctl(int type) "type %d" > kvm_run_exit(uint32_t reason) "reason %d" > + > +# qdev.c > +qdev_create(void *dev, void *bus) "dev %p, bus %p" > +qdev_free(void *dev, void *bus) "dev %p, bus %p" >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg