Re: [PATCH v2 1/4] iio: adc: Document the regulator/clocks for exynos-adc

[Lars-Peter Clausen <lars@metafoo.de>]

On 03/27/2013 07:35 PM, Naveen Krishna Ch wrote:
> On 13 March 2013 13:39, Doug Anderson <dianders@chromium.org> wrote:
>> The exynos ADC won't work without a regulator called "vdd" and a clock
>> called "adc".  Document this fact in the device tree bindings.
>>
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Reviewed-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> 
> Lars, any update on this patch set. This change is required.

Uhm, looks fine to me. I'm sure Jonathan will pick it up :)

>> ---
>> Changes in v2: None
>>
>>  Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> index f686378..96db940 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> @@ -20,6 +20,9 @@ Required properties:
>>                         format is being dependent on which interrupt controller
>>                         the Samsung device uses.
>>  - #io-channel-cells = <1>; As ADC has multiple outputs
>> +- clocks               From common clock binding: handle to adc clock.
>> +- clock-names          From common clock binding: Shall be "adc".
>> +- vdd-supply           VDD input supply.
>>
>>  Note: child nodes can be added for auto probing from device tree.
>>
>> @@ -31,6 +34,11 @@ adc: adc@12D10000 {
>>         interrupts = <0 106 0>;
>>         #io-channel-cells = <1>;
>>         io-channel-ranges;
>> +
>> +       clocks = <&clock 303>;
>> +       clock-names = "adc";
>> +
>> +       vdd-supply = <&buck5_reg>;
>>  };
>>
>>
>> --
>> 1.8.1.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
> 
> --
> Shine bright,
> (: Nav :)