All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] compiler: fix warning with GCC 4.8.0
Date: Wed, 27 Mar 2013 13:33:40 -0700	[thread overview]
Message-ID: <515357A4.8000605@twiddle.net> (raw)
In-Reply-To: <1364391272-1128-1-git-send-email-pbonzini@redhat.com>

On 03/27/2013 06:34 AM, Paolo Bonzini wrote:
> GCC 4.8.0 introduces a new warning:
> 
>     block/qcow2-snapshot.c: In function 'qcow2_write_snapshots’:
>     block/qcow2-snapshot.c:252:18: error: typedef 'qemu_build_bug_on__253'
>               locally defined but not used [-Werror=unused-local-typedefs]
>          QEMU_BUILD_BUG_ON(offsetof(QCowHeader, snapshots_offset) !=
>                   ^
>     cc1: all warnings being treated as errors
> 
> (Caret diagnostics aren't perfect yet with macros... :)) Work around it
> with __attribute__((unused)).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Richard Henderson <rth@twiddle.net>

Thanks, I've just been adding -Wno-unused-local-typedefs locally for a bit.


r~

  reply	other threads:[~2013-03-27 20:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 13:34 [Qemu-devel] [PATCH] compiler: fix warning with GCC 4.8.0 Paolo Bonzini
2013-03-27 20:33 ` Richard Henderson [this message]
2013-03-27 21:15 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515357A4.8000605@twiddle.net \
    --to=rth@twiddle.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.