From: Jaehoon Chung <jh80.chung@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-mmc@vger.kernel.org, tgih.jun@samsung.com,
jh80.chung@samsung.com, cjb@laptop.org, patches@linaro.org
Subject: Re: [PATCH 2/2] mmc: dw_mmc: Use pr_info instead of printk
Date: Thu, 28 Mar 2013 13:47:55 +0900 [thread overview]
Message-ID: <5153CB7B.1010504@samsung.com> (raw)
In-Reply-To: <1364444747-16777-2-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
On 03/28/2013 01:25 PM, Sachin Kamat wrote:
> pr_info(... is preferred to printk(KERN_INFO ...
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 1ba09d0..b8582d0 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2509,7 +2509,7 @@ EXPORT_SYMBOL(dw_mci_resume);
>
> static int __init dw_mci_init(void)
> {
> - printk(KERN_INFO "Synopsys Designware Multimedia Card Interface Driver");
> + pr_info("Synopsys Designware Multimedia Card Interface Driver");
Using "...Card Interface Driver\n"?
Then this patch looks good to me.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> return 0;
> }
>
>
next prev parent reply other threads:[~2013-03-28 4:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 4:25 [PATCH 1/2] mmc: dw_mmc: Check return value of regulator_enable Sachin Kamat
2013-03-28 4:25 ` [PATCH 2/2] mmc: dw_mmc: Use pr_info instead of printk Sachin Kamat
2013-03-28 4:47 ` Jaehoon Chung [this message]
2013-03-28 4:42 ` [PATCH 1/2] mmc: dw_mmc: Check return value of regulator_enable Jaehoon Chung
2013-04-04 5:49 ` Seungwon Jeon
2013-04-04 5:56 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5153CB7B.1010504@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.