From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <saito.kazuya@jp.fujitsu.com>) id 1UL5pL-0000ZM-FX
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 01:56:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <saito.kazuya@jp.fujitsu.com>) id 1UL5pI-0002Hr-VP
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 01:56:43 -0400
Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:41909)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <saito.kazuya@jp.fujitsu.com>) id 1UL5pI-0002Hl-Fb
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 01:56:40 -0400
Received: from m4.gw.fujitsu.co.jp (unknown [10.0.50.74])
	by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 566353EE0B6
	for <qemu-devel@nongnu.org>; Thu, 28 Mar 2013 14:56:38 +0900 (JST)
Received: from smail (m4 [127.0.0.1])
	by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 3E89F45DE51
	for <qemu-devel@nongnu.org>; Thu, 28 Mar 2013 14:56:38 +0900 (JST)
Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94])
	by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 28CC145DE4D
	for <qemu-devel@nongnu.org>; Thu, 28 Mar 2013 14:56:38 +0900 (JST)
Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1])
	by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 166DDE08004
	for <qemu-devel@nongnu.org>; Thu, 28 Mar 2013 14:56:38 +0900 (JST)
Received: from g01jpexchkw04.g01.fujitsu.local
	(g01jpexchkw04.g01.fujitsu.local [10.0.194.43])
	by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id C2E73E08002
	for <qemu-devel@nongnu.org>; Thu, 28 Mar 2013 14:56:37 +0900 (JST)
Message-ID: <5153DB8A.4030907@jp.fujitsu.com>
Date: Thu, 28 Mar 2013 14:56:26 +0900
From: Kazuya Saito <saito.kazuya@jp.fujitsu.com>
MIME-Version: 1.0
References: <514C1560.1020406@jp.fujitsu.com>
	<514C1656.8020503@jp.fujitsu.com> <5152D20B.5090101@suse.de>
In-Reply-To: <5152D20B.5090101@suse.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 4/5] qdev: add qdev_{create,
	free} tracepoints
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

(2013/03/27 20:03), Andreas Färber wrote:> Am 22.03.2013 09:29, schrieb Kazuya Saito:
>> This patch adds tracepoints at creating and removing virtual
>> devices. It is useful for investigation of trouble related to virtual
>> devices.
>>
>> Signed-off-by: Kazuya Saito <saito.kazuya@jp.fujitsu.com>
>
> I would prefer not to do this. I had previously posted a patch to remove
> qdev_free() in favor of using the QOM function object_unparent()
> directly, which adding stuff to qdev_free() would interfere with. And
> you should rather add a tracepoint to object_new() or better to
> object_initialize() than into the legacy qdev_create() - which doesn't
> cover qdev_try_create() btw. Either way, adding new tracepoints with the
> legacy "qdev" in the name is ugly.

Just as I replied to Paolo, I won't add these tracepoints. Thank you for
your good information.

> Regards,
> Andreas
>
> P.S. Your patches arrived in HTML format, please check your workflow.

I checked and modified the setting. Did this mail arrive in plain-text?

Kazuya